chrome/browser/resources/chromeos/chromevox/common/page_selection.js - Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/common/page_selection.js

Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@inputtypeexception

Patch Set: Move another braille message to Msgs.Untranslated Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/common/node_state.js ('k') | chrome/browser/resources/chromeos/chromevox/common/time_widget.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/common/page_selection.js

diff --git a/chrome/browser/resources/chromeos/chromevox/common/page_selection.js b/chrome/browser/resources/chromeos/chromevox/common/page_selection.js

index de87d9f69587dcb277fa628a89e91bd8e1b90e23..7a46db20669b5ad24a436be2df2d4aa9d4eb9530 100644

--- a/chrome/browser/resources/chromeos/chromevox/common/page_selection.js

+++ b/chrome/browser/resources/chromeos/chromevox/common/page_selection.js

@@ -45,18 +45,18 @@ cvox.PageSelection.prototype.getDescription =

if (this.sel_.isReversed() != curSel.isReversed()) {

// A shrinking selection.

desc = navShifter.getDescription(curSel, prevSel);

- desc[0].annotation = cvox.ChromeVox.msgs.getMsg('describe_unselected');

+ desc[0].annotation = Msgs.getMsg('describe_unselected');

desc[0].pushEarcon(cvox.Earcon.SELECTION_REVERSE);

} else {

// A growing selection.

desc = navShifter.getDescription(prevSel, curSel);

- desc[0].annotation = cvox.ChromeVox.msgs.getMsg('describe_selected');

+ desc[0].annotation = Msgs.getMsg('describe_selected');

desc[0].pushEarcon(cvox.Earcon.SELECTION);

if (!this.wasBegin_ && this.sel_.absEquals(curSel.clone().normalize())) {

// A selection has inverted across the start cursor. Describe it.

var prevDesc = navShifter.getDescription(curSel, prevSel);

prevDesc[0].annotation =

- cvox.ChromeVox.msgs.getMsg('describe_unselected');

+ Msgs.getMsg('describe_unselected');

prevDesc[0].pushEarcon(cvox.Earcon.SELECTION_REVERSE);

prevDesc[0].pushEarcon(cvox.Earcon.WRAP);

desc = prevDesc.concat(desc);

@@ -76,7 +76,7 @@ cvox.PageSelection.prototype.getDescription =

cvox.PageSelection.prototype.getFullDescription = function() {

return [new cvox.NavDescription(

{text: window.getSelection().toString(),

- context: cvox.ChromeVox.msgs.getMsg('selection_is')})];

+ context: Msgs.getMsg('selection_is')})];

};