chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/keyboard_help_widget.js - Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/keyboard_help_widget.js

Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@inputtypeexception

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/chromevox/injected/loader.js ('K') | « chrome/browser/resources/chromeos/chromevox/chromevox/injected/pdf_processor.js ('k') | chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/node_search_widget.js » ('j') | chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/spoken_messages.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/keyboard_help_widget.js

diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/keyboard_help_widget.js b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/keyboard_help_widget.js

index 7fcee8d0f4725e8082d1e84099de886d1243964a..bde0aab057db9d285e7f5bd5baf998fe669e583a 100644

--- a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/keyboard_help_widget.js

+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/keyboard_help_widget.js

@@ -33,7 +33,7 @@ cvox.KeyboardHelpWidget = function() {

if (!id) {

return;

}

- message = cvox.ChromeVox.msgs.getMsg(id);

+ message = Msgs.getMsg(id);

} catch (e) {

// TODO(dtseng): We have some commands that don't have valid message id's.

}