chrome/browser/resources/chromeos/chromevox/chromevox/injected/pdf_processor.js - Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/injected/pdf_processor.js

Issue 1362223003: Improve braille related message descriptions and clean up message handling in Chromevox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@inputtypeexception

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/chromevox/injected/loader.js ('K') | « chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_shifter.js ('k') | chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/keyboard_help_widget.js » ('j') | chrome/browser/resources/chromeos/chromevox/chromevox/injected/ui/spoken_messages.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/chromevox/injected/pdf_processor.js

diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/pdf_processor.js b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/pdf_processor.js

index 1ba8973ba16308d4964ca1e2436b282525ba8925..92650ce0bb219ceb0ae8f1d3ad8a014517d9464b 100644

--- a/chrome/browser/resources/chromeos/chromevox/chromevox/injected/pdf_processor.js

+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/injected/pdf_processor.js

@@ -144,8 +144,7 @@ cvox.PdfProcessor.onMessage = function(message) {

var src = cvox.PdfProcessor.pdfEmbed.src;

var filename = src.substr(src.lastIndexOf('/') + 1);

document.title = filename;

- var html = cvox.ChromeVox.msgs.getMsg(

- 'pdf_header', [filename, src + '#original']);

+ var html = Msgs.getMsg('pdf_header', [filename, src + '#original']);

headerDiv.innerHTML = html;

// Set up a handler to reload the page when 'Show original' is clicked.

var showLink = headerDiv.getElementsByTagName('a')[0];

@@ -164,7 +163,7 @@ cvox.PdfProcessor.onMessage = function(message) {

if (!info.copyable) {

var alert = document.createElement('div');

alert.setAttribute('role', 'alert');

- alert.innerText = cvox.ChromeVox.msgs.getMsg('copy_protected_pdf');

+ alert.innerText = Msgs.getMsg('copy_protected_pdf');

cvox.PdfProcessor.documentDiv.appendChild(alert);

cvox.PdfProcessor.pdfEmbed.parentElement.appendChild(

cvox.PdfProcessor.documentDiv);