Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: lib/src/backend/declarer.dart

Issue 1361303002: Get rid of LocalTest.tearDown. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/src/backend/invoker.dart » ('j') | lib/src/backend/invoker.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/backend/declarer.dart
diff --git a/lib/src/backend/declarer.dart b/lib/src/backend/declarer.dart
index d2e2c4fe30d5bdd74a0d2ea361dfb8cba6d911f1..55c7ea79252799424b25146c45803d6930e897d4 100644
--- a/lib/src/backend/declarer.dart
+++ b/lib/src/backend/declarer.dart
@@ -45,8 +45,10 @@ class Declarer {
// TODO(nweiz): Use async/await here once issue 23497 has been fixed in
// two stable versions.
- return group.runSetUp().then((_) => body());
- }, tearDown: group.runTearDown));
+ return Invoker.current.waitForOutstandingCallbacks(() {
+ return group.runSetUp().then((_) => body());
+ }).then((_) => group.runTearDown());
Bob Nystrom 2015/09/24 16:05:02 Should this be whenComplete() or are errors alread
nweiz 2015/09/24 19:56:20 waitForOutstandingCallbacks has a zone error handl
+ }));
}
/// Creates a group of tests.
« no previous file with comments | « no previous file | lib/src/backend/invoker.dart » ('j') | lib/src/backend/invoker.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698