Get rid of LocalTest.tearDown.

lib/src/backend/declarer.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.backend.declarer;
 
 import 'dart:collection';
 
 import '../frontend/timeout.dart';
 import 'group.dart';
@@ skipping 27 matching lines @@
         testOn: testOn, timeout: timeout, skip: skip, onPlatform: onPlatform));
 
     var group = _group;
     _tests.add(new LocalTest(description, metadata, () {
       // TODO(nweiz): It might be useful to throw an error here if a test starts
       // running while other tests from the same declarer are also running,
       // since they might share closurized state.
 
       // TODO(nweiz): Use async/await here once issue 23497 has been fixed in
       // two stable versions.
-      return group.runSetUp().then((_) => body());
-    }, tearDown: group.runTearDown));
+      return Invoker.current.waitForOutstandingCallbacks(() {
+        return group.runSetUp().then((_) => body());
+      }).then((_) => group.runTearDown());

[Bob Nystrom, 2015/09/24 16:05:02]

Should this be whenComplete() or are errors already handled before we get here?

[nweiz, 2015/09/24 19:56:20]

waitForOutstandingCallbacks has a zone error handler, so it won't ever throw.

+    }));
   }
 
   /// Creates a group of tests.
   void group(String description, void body(), {String testOn,
       Timeout timeout, skip, Map<String, dynamic> onPlatform}) {
     var oldGroup = _group;
 
     var metadata = new Metadata.parse(
         testOn: testOn, timeout: timeout, skip: skip, onPlatform: onPlatform);
 
@@ skipping 24 matching lines @@
   /// Registers a function to be run after tests.
   void tearDown(callback()) {
     if (_group.tearDown != null) {
       throw new StateError("tearDown() may not be called multiple times for "
           "the same group.");
     }
 
     _group.tearDown = callback;
   }
 }