Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 1361263004: GN: Don't allow nested things inside template invocations. (Closed)

Created:
5 years, 2 months ago by brettw
Modified:
5 years, 2 months ago
Reviewers:
Bons
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Don't allow nested things inside template invocations. Previously we would allow this because "component" is a template: component("foo") { config("bar") { } } This patch makes this construct illegal. Allowing this leads to weird errors because the template invocation will have default configs applied to it, and the inner config will pick those up and duplicate all of the target's configs inside of "bar". Also removes unused "Type" enum which was never used. BUG=536290 Committed: https://crrev.com/c5598930514b13c0c36992e47d8b5170730001ce Cr-Commit-Position: refs/heads/master@{#351000}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M tools/gn/functions.h View 1 chunk +0 lines, -8 lines 1 comment Download
M tools/gn/template.cc View 1 chunk +14 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
5 years, 2 months ago (2015-09-26 05:01:26 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361263004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361263004/20001
5 years, 2 months ago (2015-09-26 05:01:42 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-26 05:14:01 UTC) #6
Bons
lgtm https://codereview.chromium.org/1361263004/diff/20001/tools/gn/functions.h File tools/gn/functions.h (left): https://codereview.chromium.org/1361263004/diff/20001/tools/gn/functions.h#oldcode438 tools/gn/functions.h:438: enum Type { yay dead code removal!
5 years, 2 months ago (2015-09-26 11:13:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1361263004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1361263004/20001
5 years, 2 months ago (2015-09-26 16:35:33 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-26 18:08:05 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-26 18:08:50 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c5598930514b13c0c36992e47d8b5170730001ce
Cr-Commit-Position: refs/heads/master@{#351000}

Powered by Google App Engine
This is Rietveld 408576698