Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: tools/gn/functions.h

Issue 1361263004: GN: Don't allow nested things inside template invocations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/template.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/functions.h
diff --git a/tools/gn/functions.h b/tools/gn/functions.h
index f9c867d8093cc8c64eb5eff36f1e4791a59d03a8..262fc60480258193d0e217f822d09d11fb0cbf36 100644
--- a/tools/gn/functions.h
+++ b/tools/gn/functions.h
@@ -435,14 +435,6 @@ Label MakeLabelForScope(const Scope* scope,
// there is already another non-nestable block on the stack.
class NonNestableBlock {
public:
- enum Type {
Bons 2015/09/26 11:13:34 yay dead code removal!
- CONFIG,
- DECLARE_ARGS,
- TARGET,
- TEMPLATE,
- TOOLCHAIN,
- };
-
// type_description is a string that will be used in error messages
// describing the type of the block, for example, "template" or "config".
NonNestableBlock(Scope* scope,
« no previous file with comments | « no previous file | tools/gn/template.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698