Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: chrome/browser/ui/startup/obsolete_system_infobar_delegate.cc

Issue 1361253002: Separate the URL of an infobar link with clicking on it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fit Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/startup/obsolete_system_infobar_delegate.cc
diff --git a/chrome/browser/ui/startup/obsolete_system_infobar_delegate.cc b/chrome/browser/ui/startup/obsolete_system_infobar_delegate.cc
index 233451f423bd548dc72cc7a180803c609f70bfa6..897c8387bb17ed6ced6e7a1746771e7f24b636c3 100644
--- a/chrome/browser/ui/startup/obsolete_system_infobar_delegate.cc
+++ b/chrome/browser/ui/startup/obsolete_system_infobar_delegate.cc
@@ -54,15 +54,19 @@ base::string16 ObsoleteSystemInfoBarDelegate::GetLinkText() const {
return l10n_util::GetStringUTF16(IDS_LEARN_MORE);
}
+GURL ObsoleteSystemInfoBarDelegate::GetLinkURL() const {
+#if defined(OS_MACOSX)
+ return GURL(chrome::kMac32BitDeprecationURL);
+#else
+ return GURL("https://support.google.com/chrome/answer/95411");
+#endif
+}
+
bool ObsoleteSystemInfoBarDelegate::LinkClicked(
WindowOpenDisposition disposition) {
InfoBarService::WebContentsFromInfoBar(infobar())->OpenURL(
content::OpenURLParams(
-#if defined(OS_MACOSX)
- GURL(chrome::kMac32BitDeprecationURL),
-#else
- GURL("https://support.google.com/chrome/answer/95411"),
-#endif
+ GetLinkURL(),
content::Referrer(),
(disposition == CURRENT_TAB) ? NEW_FOREGROUND_TAB : disposition,
ui::PAGE_TRANSITION_LINK, false));

Powered by Google App Engine
This is Rietveld 408576698