Separate the URL of an infobar link with clicking on it.

chrome/browser/ui/confirm_bubble_model.h

Index: chrome/browser/ui/confirm_bubble_model.h
diff --git a/chrome/browser/ui/confirm_bubble_model.h b/chrome/browser/ui/confirm_bubble_model.h
index 3406016c7de0276c755c7f9e77e323fd52de91a3..33405eb0d1c38becefe94d92cbc2e1300bcb4167 100644
--- a/chrome/browser/ui/confirm_bubble_model.h
+++ b/chrome/browser/ui/confirm_bubble_model.h
@@ -7,6 +7,7 @@
 
 #include "base/basictypes.h"
 #include "base/strings/string16.h"
+#include "url/gurl.h"
 
 namespace gfx {
 class Image;
@@ -49,10 +50,13 @@ class ConfirmBubbleModel {
   virtual void Cancel();
 
   // Returns the text of the link to be displayed, if any. Otherwise returns
-  // and empty string.
+  // an empty string.
   virtual base::string16 GetLinkText() const;
 
-  // Called when the Link is clicked.
+  // Returns the URL of the link to be displayed.
+  virtual GURL GetLinkURL() const;

[Peter Kasting, 2015/09/24 21:18:27]

I don't think you should be modifying this class or its subclasses, as they're
not infobar delegates.

This also means reverting the Mac changes that called this new method.

[Avi (use Gerrit), 2015/09/30 22:58:33]

This interface is identical to the toolbar interface, down to the typos in the
comment for GetLinkText(). It suffers exactly the same problem as the toolbar
interface, and I need to provide the exact same solution for it. I think it
makes sense to include it in this change if we're making the same changes to it.

[Peter Kasting, 2015/10/01 00:10:58]

I'm not objecting to the fix, I just would have prefered not to touch
non-infobar-related APIs in a change nominally about infobars.

It doesn't matter much; the change is clearly correct.

+
+  // Called when the link is clicked.
   virtual void LinkClicked();
 
  private: