Separate the URL of an infobar link with clicking on it.

chrome/browser/plugins/plugin_infobar_delegates.cc

Index: chrome/browser/plugins/plugin_infobar_delegates.cc
diff --git a/chrome/browser/plugins/plugin_infobar_delegates.cc b/chrome/browser/plugins/plugin_infobar_delegates.cc
index 01739b4ecefc486338c806761237aab6ec138b47..0594234d3858aa375dd6c5e3b7b3c003fe5e6d84 100644
--- a/chrome/browser/plugins/plugin_infobar_delegates.cc
+++ b/chrome/browser/plugins/plugin_infobar_delegates.cc
@@ -60,7 +60,7 @@ PluginInfoBarDelegate::~PluginInfoBarDelegate() {
 bool PluginInfoBarDelegate::LinkClicked(WindowOpenDisposition disposition) {
   InfoBarService::WebContentsFromInfoBar(infobar())->OpenURL(
       content::OpenURLParams(
-          GURL(GetLearnMoreURL()), content::Referrer(),
+          GetLinkURL(), content::Referrer(),
           (disposition == CURRENT_TAB) ? NEW_FOREGROUND_TAB : disposition,
           ui::PAGE_TRANSITION_LINK, false));
   return false;
@@ -81,6 +81,10 @@ base::string16 PluginInfoBarDelegate::GetLinkText() const {
   return l10n_util::GetStringUTF16(IDS_LEARN_MORE);
 }
 
+GURL PluginInfoBarDelegate::GetLinkURL() const {
+  return GURL(GetLearnMoreURL());

[Peter Kasting, 2015/09/24 21:18:27]

We should just eliminate GetLearnMoreURL() and either move its implementation to
here (if there is only one implementation) or override GetLinkURL() in
subclasses as needed.

+}
+
 #if defined(ENABLE_PLUGIN_INSTALLATION)
 
 // OutdatedPluginInfoBarDelegate ----------------------------------------------
@@ -297,6 +301,12 @@ base::string16 PluginMetroModeInfoBarDelegate::GetLinkText() const {
   return l10n_util::GetStringUTF16(IDS_LEARN_MORE);
 }
 
+GURL PluginMetroModeInfoBarDelegate::GetLinkURL() const {
+  return GURL((mode_ == MISSING_PLUGIN) ?
+              "https://support.google.com/chrome/?p=ib_display_in_desktop" :
+              "https://support.google.com/chrome/?p=ib_redirect_to_desktop");
+}
+
 bool PluginMetroModeInfoBarDelegate::LinkClicked(
     WindowOpenDisposition disposition) {
   // TODO(shrikant): We may need to change language a little at following
@@ -304,9 +314,7 @@ bool PluginMetroModeInfoBarDelegate::LinkClicked(
   // and not missing mode.
   InfoBarService::WebContentsFromInfoBar(infobar())->OpenURL(
       content::OpenURLParams(
-          GURL((mode_ == MISSING_PLUGIN) ?
-              "https://support.google.com/chrome/?p=ib_display_in_desktop" :
-              "https://support.google.com/chrome/?p=ib_redirect_to_desktop"),
+          GetLinkURL(),
           content::Referrer(),
           (disposition == CURRENT_TAB) ? NEW_FOREGROUND_TAB : disposition,
           ui::PAGE_TRANSITION_LINK, false));