Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: chrome/browser/pepper_broker_infobar_delegate.cc

Issue 1361253002: Separate the URL of an infobar link with clicking on it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fit Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/pepper_broker_infobar_delegate.cc
diff --git a/chrome/browser/pepper_broker_infobar_delegate.cc b/chrome/browser/pepper_broker_infobar_delegate.cc
index 65f866f07e6562515e5841eb06494023d2b6d791..ef1856ea91d77d1d4ed4b700fe1893dde3c9b589 100644
--- a/chrome/browser/pepper_broker_infobar_delegate.cc
+++ b/chrome/browser/pepper_broker_infobar_delegate.cc
@@ -130,12 +130,15 @@ base::string16 PepperBrokerInfoBarDelegate::GetLinkText() const {
return l10n_util::GetStringUTF16(IDS_LEARN_MORE);
}
+GURL PepperBrokerInfoBarDelegate::GetLinkURL() const {
+ return GURL("https://support.google.com/chrome/?p=ib_pepper_broker");
+}
+
bool PepperBrokerInfoBarDelegate::LinkClicked(
WindowOpenDisposition disposition) {
- GURL learn_more_url("https://support.google.com/chrome/?p=ib_pepper_broker");
InfoBarService::WebContentsFromInfoBar(infobar())->OpenURL(
content::OpenURLParams(
- learn_more_url, content::Referrer(),
+ GetLinkURL(), content::Referrer(),
(disposition == CURRENT_TAB) ? NEW_FOREGROUND_TAB : disposition,
ui::PAGE_TRANSITION_LINK, false));
return false;

Powered by Google App Engine
This is Rietveld 408576698