[Interpreter] Add support for loading globals in the interpreter.

[Interpreter] Add support for loading globals in the interpreter.

Adds LdaGlobal bytecode and augments BytecodeGenerator to load globals for
global variables and function calls.

Modified TestBytecodeGenerator to add the ability to specify that a bytecode
operand has an unknown value (used so we don't need to figure out the slot
index of a global). Also added a helper which checks equality of BytecodeArray
with the expected snipptets.

Modified TestInterpreter to allow it to take snippets of JS and have the
BytecodeGenerator generate the bytecode rather than having to build a
BytecodeArray manually. This is used to enable the global tests.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/8087c49dc763558368ea15f69d5f6247c287515f
Cr-Commit-Position: refs/heads/master@{#30910}

[rmcilroy, 2015-09-23 13:13:09]

Patchset #2 (id:20001) has been deleted

[rmcilroy, 2015-09-23 13:13:26]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-23 13:13:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1361113002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1361113002/1

[rmcilroy, 2015-09-23 13:13:51]

rmcilroy@chromium.org changed reviewers:
+ mstarzinger@chromium.org, oth@chromium.org

[rmcilroy, 2015-09-23 13:13:52]

Michi, Orion, please take a look, thanks.

[commit-bot: I haz the power, 2015-09-23 13:17:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 13:17:13]

Dry run: Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6016)

[rmcilroy, 2015-09-23 15:42:03]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-23 15:42:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1361113002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1361113002/40001

[commit-bot: I haz the power, 2015-09-23 15:45:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 15:45:33]

Dry run: Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6023)

[Michael Starzinger, 2015-09-24 08:54:54]

LGTM from my end.

https://codereview.chromium.org/1361113002/diff/40001/src/interpreter/bytecod...
File src/interpreter/bytecode-array-iterator.h (right):

https://codereview.chromium.org/1361113002/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-array-iterator.h:32: uint8_t GetRawOperand(int
operand_index) const;
nit: IIUC this is only exposed for testing. Can we leave a comment in that
regard so that people are more inclined to use the above checked getters?

[oth, 2015-09-24 10:14:00]

LGTM. Minor comment about GetRawOperand as discussed. Great to centralize the
bytecode array validation.

https://codereview.chromium.org/1361113002/diff/40001/src/interpreter/bytecod...
File src/interpreter/bytecode-array-iterator.cc (right):

https://codereview.chromium.org/1361113002/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-array-iterator.cc:35: uint8_t
BytecodeArrayIterator::GetRawOperand(int operand_index) const {
Although more work in the test, making GetOperand public would limit potential
misuses of GetRawOperand().

[rmcilroy, 2015-09-24 11:20:12]

Thanks for the comments!

https://codereview.chromium.org/1361113002/diff/40001/src/interpreter/bytecod...
File src/interpreter/bytecode-array-iterator.cc (right):

https://codereview.chromium.org/1361113002/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-array-iterator.cc:35: uint8_t
BytecodeArrayIterator::GetRawOperand(int operand_index) const {
On 2015/09/24 10:14:00, oth wrote:
> Although more work in the test, making GetOperand public would limit potential
> misuses of GetRawOperand().

Sounds good, done.

https://codereview.chromium.org/1361113002/diff/40001/src/interpreter/bytecod...
File src/interpreter/bytecode-array-iterator.h (right):

https://codereview.chromium.org/1361113002/diff/40001/src/interpreter/bytecod...
src/interpreter/bytecode-array-iterator.h:32: uint8_t GetRawOperand(int
operand_index) const;
On 2015/09/24 08:54:54, Michael Starzinger wrote:
> nit: IIUC this is only exposed for testing. Can we leave a comment in that
> regard so that people are more inclined to use the above checked getters?

Changed to add an OperandType and add checking as suggested by Orion. Also added
comment.

[rmcilroy, 2015-09-24 11:20:16]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2015-09-24 11:20:16]

The patchset sent to the CQ was uploaded after l-g-t-m from oth@chromium.org,
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1361113002/#ps60001
(title: "Review comments and fix ASAN")

[commit-bot: I haz the power, 2015-09-24 11:20:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1361113002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1361113002/60001

[commit-bot: I haz the power, 2015-09-24 11:24:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-24 11:24:19]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6040)

[rmcilroy, 2015-09-24 11:46:04]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2015-09-24 11:46:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1361113002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1361113002/60001

[commit-bot: I haz the power, 2015-09-24 11:48:32]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-09-24 11:48:47]

Patchset 3 (id:??) landed as
https://crrev.com/8087c49dc763558368ea15f69d5f6247c287515f
Cr-Commit-Position: refs/heads/master@{#30910}