Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 136093005: A64: Move integer exponent into correct register before calling MathPowStub. (Closed)

Created:
6 years, 10 months ago by ulan
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Move integer exponent into correct register before calling MathPowStub. Follow-up to r18911. TEST=mozilla/ecma/Expressions/11.7.1 R=baptiste.afsa@arm.com, jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18924

Patch Set 1 #

Total comments: 3

Patch Set 2 : Use register constraints. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M src/a64/lithium-a64.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
M src/a64/lithium-codegen-a64.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
ulan
PTAL https://codereview.chromium.org/136093005/diff/1/src/a64/lithium-codegen-a64.cc File src/a64/lithium-codegen-a64.cc (right): https://codereview.chromium.org/136093005/diff/1/src/a64/lithium-codegen-a64.cc#newcode3788 src/a64/lithium-codegen-a64.cc:3788: __ Mov(x12, x11); MathPowStub expects integer exponent in ...
6 years, 10 months ago (2014-01-29 15:13:41 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-01-29 15:19:36 UTC) #2
baptiste.afsa1
https://codereview.chromium.org/136093005/diff/1/src/a64/lithium-codegen-a64.cc File src/a64/lithium-codegen-a64.cc (right): https://codereview.chromium.org/136093005/diff/1/src/a64/lithium-codegen-a64.cc#newcode3788 src/a64/lithium-codegen-a64.cc:3788: __ Mov(x12, x11); Isn't it possible to modify register ...
6 years, 10 months ago (2014-01-29 15:23:48 UTC) #3
ulan
Thanks! Uploaded new patch set, PTAL. https://codereview.chromium.org/136093005/diff/1/src/a64/lithium-codegen-a64.cc File src/a64/lithium-codegen-a64.cc (right): https://codereview.chromium.org/136093005/diff/1/src/a64/lithium-codegen-a64.cc#newcode3788 src/a64/lithium-codegen-a64.cc:3788: __ Mov(x12, x11); ...
6 years, 10 months ago (2014-01-29 15:33:14 UTC) #4
baptiste.afsa1
lgtm
6 years, 10 months ago (2014-01-29 15:37:19 UTC) #5
ulan
6 years, 10 months ago (2014-01-29 15:50:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r18924 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698