Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1360903004: [heap] Move large object space selection into AllocateRaw. (Closed)

Created:
5 years, 2 months ago by Hannes Payer (out of office)
Modified:
5 years, 2 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Move large object space selection into AllocateRaw. BUG= Committed: https://crrev.com/1403815bdbcbd3336b2d85291704640fada30ffe Cr-Commit-Position: refs/heads/master@{#30930}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -34 lines) Patch
M src/heap/heap.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/heap/heap.cc View 12 chunks +12 lines, -15 lines 0 comments Download
M src/heap/heap-inl.h View 3 chunks +17 lines, -15 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
Hannes Payer (out of office)
https://codereview.chromium.org/1360903004/diff/1/src/heap/heap-inl.h File src/heap/heap-inl.h (left): https://codereview.chromium.org/1360903004/diff/1/src/heap/heap-inl.h#oldcode216 src/heap/heap-inl.h:216: if (allocation.To(&object)) { This branch will be taken in ...
5 years, 2 months ago (2015-09-25 10:19:15 UTC) #2
Michael Lippautz
LGTM
5 years, 2 months ago (2015-09-25 10:33:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360903004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360903004/1
5 years, 2 months ago (2015-09-25 10:35:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-25 10:41:07 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1403815bdbcbd3336b2d85291704640fada30ffe Cr-Commit-Position: refs/heads/master@{#30930}
5 years, 2 months ago (2015-09-25 10:41:26 UTC) #7
Michael Achenbach
5 years, 2 months ago (2015-09-25 11:27:26 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1368103002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20...

And maybe (not sure):
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064%20%2....

Powered by Google App Engine
This is Rietveld 408576698