Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1360863004: Snap screen rotation animation layers to final position if the animation is aborted. (Closed)

Created:
5 years, 3 months ago by bruthig
Modified:
5 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@2454
Target Ref:
refs/pending/branch-heads/2454
Project:
chromium
Visibility:
Public.

Description

Snap screen rotation animation layers to final position if the animation is aborted. Some users were seeing incorrectly aligned and rotated backgrounds while at the lock screen. It was possible that the session state animations were aborting the screen rotation animations prematurely and thus they would get stuck in a bad position. TBR=oshima@chromium.org TEST=ScreenRotationAnimationTest.LayerTransformGetsSetToTargetWhenAborted BUG=496986 Review URL: https://codereview.chromium.org/1315573003 Cr-Commit-Position: refs/heads/master@{#348734} (cherry picked from commit ca01f9e55651e4a7285f551e83bd561b01787c19) Committed: https://chromium.googlesource.com/chromium/src/+/a46fd8c576eafecfef5abeffbd0be73f4c3de7b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -0 lines) Patch
M ash/ash.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ash/rotator/screen_rotation_animation.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A ash/rotator/screen_rotation_animation_unittest.cc View 1 chunk +73 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
bruthig
oshima@, I've TBR'ed you on this merge back to M45. Can you take a look ...
5 years, 3 months ago (2015-09-23 18:33:33 UTC) #1
bruthig
5 years, 3 months ago (2015-09-23 18:36:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a46fd8c576eafecfef5abeffbd0be73f4c3de7b2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698