Snap screen rotation animation layers to final position if the animation is aborted.

Snap screen rotation animation layers to final position if the animation is aborted.

Some users were seeing incorrectly aligned and rotated backgrounds while
at the lock screen.  It was possible that the session state animations
were aborting the screen rotation animations prematurely and thus they
would get stuck in a bad position.

TEST=ScreenRotationAnimationTest.LayerTransformGetsSetToTargetWhenAborted

BUG=496986
Committed: https://crrev.com/ca01f9e55651e4a7285f551e83bd561b01787c19
Cr-Commit-Position: refs/heads/master@{#348734}

[bruthig, 2015-09-04 19:45:32]

bruthig@chromium.org changed reviewers:
+ oshima@chromium.org

[bruthig, 2015-09-04 19:45:32]

oshima@: Can you please have a look?

[oshima, 2015-09-04 19:50:35]

https://codereview.chromium.org/1315573003/diff/1/ash/rotator/screen_rotation...
File ash/rotator/screen_rotation_animation.cc (right):

https://codereview.chromium.org/1315573003/diff/1/ash/rotator/screen_rotation...
ash/rotator/screen_rotation_animation.cc:66:
delegate->SetTransformFromAnimation(target_value.transform);
Is it possible to have a test for this?

[bruthig, 2015-09-14 20:14:12]

I've added a test.

oshima@: PTAL

https://codereview.chromium.org/1315573003/diff/1/ash/rotator/screen_rotation...
File ash/rotator/screen_rotation_animation.cc (right):

https://codereview.chromium.org/1315573003/diff/1/ash/rotator/screen_rotation...
ash/rotator/screen_rotation_animation.cc:66:
delegate->SetTransformFromAnimation(target_value.transform);
On 2015/09/04 19:50:35, oshima wrote:
> Is it possible to have a test for this?

Done.

[oshima, 2015-09-14 20:45:48]

lgtm

Assuming you have confirmed that the test fails without this fix.

https://codereview.chromium.org/1315573003/diff/20001/ash/rotator/screen_rota...
File ash/rotator/screen_rotation_animation_unittest.cc (right):

https://codereview.chromium.org/1315573003/diff/20001/ash/rotator/screen_rota...
ash/rotator/screen_rotation_animation_unittest.cc:26: 
nit: // AshTestBase:

[bruthig, 2015-09-14 20:49:05]

The CQ bit was checked by bruthig@chromium.org

[bruthig, 2015-09-14 20:49:10]

The CQ bit was unchecked by bruthig@chromium.org

[bruthig, 2015-09-14 20:50:39]

https://codereview.chromium.org/1315573003/diff/20001/ash/rotator/screen_rota...
File ash/rotator/screen_rotation_animation_unittest.cc (right):

https://codereview.chromium.org/1315573003/diff/20001/ash/rotator/screen_rota...
ash/rotator/screen_rotation_animation_unittest.cc:26: 
On 2015/09/14 20:45:48, oshima wrote:
> nit: // AshTestBase:

Done.

[bruthig, 2015-09-14 20:52:37]

The CQ bit was checked by bruthig@chromium.org

[bruthig, 2015-09-14 20:52:37]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/1315573003/#ps20002
(title: "Added // AshTestBase: to override list.")

[commit-bot: I haz the power, 2015-09-14 20:54:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1315573003/20002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1315573003/20002

[commit-bot: I haz the power, 2015-09-14 21:58:57]

Committed patchset #3 (id:20002)

[commit-bot: I haz the power, 2015-09-14 22:00:14]

Patchset 3 (id:??) landed as
https://crrev.com/ca01f9e55651e4a7285f551e83bd561b01787c19
Cr-Commit-Position: refs/heads/master@{#348734}

[commit-bot: I haz the power, 2015-09-23 12:37:51]

Patchset 3 (id:??) landed as
https://crrev.com/ca01f9e55651e4a7285f551e83bd561b01787c19
Cr-Commit-Position: refs/heads/master@{#348734}