rAc: don't clobber user input when accepting autofill popup suggestion

chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
index efff4f6e8cef18ad352f3d008e050ea50c861a72..ad78f973cf0bf7c6b0ebc7f1c9ae7654a0216a37 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
@@ -840,7 +840,7 @@ void AutofillDialogControllerImpl::EditClickedForSection(
   scoped_ptr<DataModelWrapper> model = CreateWrapper(section);
   model->FillInputs(inputs);
   section_editing_state_[section] = true;
-  view_->UpdateSection(section);
+  view_->UpdateSection(section, true);
 }
 
 void AutofillDialogControllerImpl::EditCancelledForSection(
@@ -849,7 +849,7 @@ void AutofillDialogControllerImpl::EditCancelledForSection(
   for (size_t i = 0; i < inputs->size(); ++i)
     (*inputs)[i].initial_value.clear();
   section_editing_state_[section] = false;
-  view_->UpdateSection(section);
+  view_->UpdateSection(section, true);
 }
 
 gfx::Image AutofillDialogControllerImpl::IconForField(
@@ -1259,7 +1259,7 @@ void AutofillDialogControllerImpl::DidAcceptSuggestion(const string16& value,
   FillInputFromFormGroup(
       form_group,
       MutableRequestedFieldsForSection(section_showing_popup_));
-  view_->UpdateSection(section_showing_popup_);
+  view_->UpdateSection(section_showing_popup_, false);

[Ilya Sherman, 2013/04/04 03:59:55]

Why is it the view's responsibility to deal with whether or not to clear the
user input?  How will the view remember which fields to clobber or not if it
ever needs to re-query the controller later?  It seems like the controller
should just correctly update the inputs returned by
MutableRequestFieldsForSection().

[Evan Stade, 2013/04/04 17:56:51]

because the view handles user input
I'm not quite sure what you mean by this. Could you clarify?
DetailInput is a struct that describes how to init a textfield. The textfields
(and their contents) are part of the presentation layer.

[Ilya Sherman, 2013/04/04 23:11:02]

Ok, I guess the view code isn't likely to ever be updated to try to read the
initial_value field from this struct at some other time, so this is probably not
an issue.

It's just weird that it *could* try to read this cached data from the controller
at any time... even though the cache might not be relevant anymore, and would be
missing the context of whether or not user input should be clobbered.

 
   metric_logger_.LogDialogPopupEvent(
       dialog_type_, AutofillMetrics::DIALOG_POPUP_FORM_FILLED);