chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc - Issue 13607006: rAc: don't clobber user input when accepting autofill popup suggestion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc

Issue 13607006: rAc: don't clobber user input when accepting autofill popup suggestion (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc

diff --git a/chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc b/chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc

index aabcd4e188bbd544a8a1c75112061a770955cd50..062cf4967f5688152f875f4f61e56be6a711de22 100644

--- a/chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc

+++ b/chrome/browser/ui/android/autofill/autofill_dialog_view_android.cc

@@ -104,7 +104,10 @@ void AutofillDialogViewAndroid::UpdateButtonStrip() {

NOTIMPLEMENTED();

}

-void AutofillDialogViewAndroid::UpdateSection(DialogSection section) {

+void AutofillDialogViewAndroid::UpdateSection(DialogSection section,

+ bool clear_user_input) {

+ // TODO(estade): respect |clear_user_input|.

JNIEnv* env = base::android::AttachCurrentThread();

const DetailInputs& updated_inputs =

controller_->RequestedFieldsForSection(section);