ios/web/web_state/ui/crw_web_controller.mm - Issue 1360543004: Manually fetch favicons after hash changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 1360543004: Manually fetch favicons after hash changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: JSON handler => string handler Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/crw_web_controller.mm

diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm

index 01d6a55bab99f5395748b249ddb4716e5b96dee0..45614483df75bda8ff038c66ee4625f5d1342d6e 100644

--- a/ios/web/web_state/ui/crw_web_controller.mm

+++ b/ios/web/web_state/ui/crw_web_controller.mm

@@ -2426,6 +2426,11 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;

context:(NSDictionary*)context {

[self checkForUnexpectedURLChange];

+ // Because hash changes don't trigger |-didFinishNavigation|, fetch favicons

+ // for the new page manually.

+ [self evaluateJavaScript:@"__gCrWeb.sendFaviconsToHost();"

+ stringResultHandler:nil];

// Notify the observers.

_webStateImpl->OnUrlHashChanged();

return YES;

« no previous file with comments | « ios/web/web_state/js/resources/core_dynamic_wk.js ('k') | no next file » | no next file with comments »