Chromium Code Reviews| OLD | NEW | 
|---|---|
| (Empty) | |
| 1 var animateRotateNoFromAxis = { | |
| 2 keyframes: [ | |
| 3 { rotate: '0deg' }, | |
| 4 { rotate: '90deg 0 1 0' }, | |
| 5 ], | |
| 6 style: `background: magenta; margin: 5px;`, | |
| 
 
alancutter (OOO until 2018)
2015/09/30 01:45:27
No need for backtick string notation here and belo
 
loyso (OOO)
2015/10/06 01:47:49
Done.
 
 | |
| 7 samples: getLinearSamples(20, 0, 1) | |
| 8 } | |
| 9 | |
| 10 var animateRotateNoToAxis = { | |
| 11 keyframes: [ | |
| 12 { rotate: '0deg 1 0 0' }, | |
| 13 { rotate: '90deg' }, | |
| 14 ], | |
| 15 style: `background: yellow; margin: 5px;`, | |
| 16 samples: getLinearSamples(20, 0, 1) | |
| 17 } | |
| 18 | |
| 19 var animateRotateFromZeroUnder360 = { | |
| 20 keyframes: [ | |
| 21 { rotate: '0deg 1 0 0' }, | |
| 22 { rotate: '90deg 0 1 0' }, | |
| 23 ], | |
| 24 style: `background: cyan; margin: 5px;`, | |
| 25 samples: getLinearSamples(20, 0, 1) | |
| 26 }; | |
| 27 | |
| 28 var animateRotateToZeroUnder360 = { | |
| 29 keyframes: [ | |
| 30 { rotate: '90deg 0 1 0' }, | |
| 31 { rotate: '0deg 1 0 0' }, | |
| 32 ], | |
| 33 style: `background: indigo; margin: 5px;`, | |
| 34 samples: getLinearSamples(20, 0, 1) | |
| 35 }; | |
| 36 | |
| 37 var animateRotateFromZero = { | |
| 38 keyframes: [ | |
| 39 { rotate: '0deg 1 0 0' }, | |
| 40 { rotate: '450deg 0 1 0' }, | |
| 41 ], | |
| 42 style: `background: green; margin: 5px;`, | |
| 43 samples: getLinearSamples(20, 0, 1) | |
| 44 }; | |
| 45 | |
| 46 var animateRotateToZero = { | |
| 47 keyframes: [ | |
| 48 { rotate: '450deg 0 1 0' }, | |
| 49 { rotate: '0deg 1 0 0' }, | |
| 50 ], | |
| 51 style: `background: red; margin: 5px;`, | |
| 52 samples: getLinearSamples(20, 0, 1) | |
| 53 } | |
| 54 | |
| 55 var animateRotateFromAndToZero = { | |
| 56 keyframes: [ | |
| 57 { rotate: '0deg 0 1 0' }, | |
| 58 { rotate: '0deg 1 0 0' }, | |
| 59 ], | |
| 60 style: `background: blue; margin: 5px;`, | |
| 
 
alancutter (OOO until 2018)
2015/09/30 01:45:27
margin: 5px; appears in every instance.
I would co
 
loyso (OOO)
2015/10/06 01:47:49
Done.
 
 | |
| 61 samples: getLinearSamples(20, 0, 1) | |
| 62 } | |
| 63 | |
| 64 var rotateZeroDegreesTests = [ | |
| 65 animateRotateNoFromAxis, | |
| 66 animateRotateNoToAxis, | |
| 67 animateRotateFromZeroUnder360, | |
| 68 animateRotateToZeroUnder360, | |
| 69 animateRotateFromZero, | |
| 70 animateRotateToZero, | |
| 71 animateRotateFromAndToZero, | |
| 72 ]; | |
| OLD | NEW |