Composited Animations: Introduce pixel-ref layout tests.

Composited Animations: Introduce pixel-ref layout tests.

We get the animation to effectively start paused at the time fraction we care about.

In order to test a number of time fractions with a single pixel result, we're creating a new
element for each sample so we can check them simultaneously.

Migrated from this blink CL: https://codereview.chromium.org/1270303002/

BUG=509482
Committed: https://crrev.com/fabe15e0f2bb2ae79e93b69828733018f5c41402
Cr-Commit-Position: refs/heads/master@{#352539}

[loyso (OOO), 2015-09-24 03:23:42]

loyso@chromium.org changed reviewers:
+ ajuma@chromium.org, alancutter@chromium.org, dstockwell@chromium.org,
vollick@chromium.org

[loyso (OOO), 2015-09-28 02:11:18]

PTAL.

[alancutter (OOO until 2018), 2015-09-30 01:45:28]

https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js
(right):

https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:7:
this.next_sample_id = 1;
Use camel cased variable names.
It's not clear what a sample is, can this be named nextInstanceId instead?

https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:32:
}`;
Can't these be part of the same stylesheet?

https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:46:
document.body.appendChild(wrapper);
We shouldn't rely on the automatic element id global variable for elements
created from Javascript since we already have the handle to them in our current
context. Just add them as members.

https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:52:
this.tests.forEach(function(test) {
Use fat arrow notation so you don't have to .bind(this) everywhere.
Alternatively just use for-of instead of forEach.

https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:59:
styleForSamples.type = 'text/css';
No need to set type.

https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:60:
styleForSamples.textContent = '.test' + testId + ' {' + test.data.style + '}';
Nit, this would be a suitable place to use backtick notation for embedded
expressions.

https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:63:
if (test.data.markerStyle && test.data.markerStyle != '') {
No need to check for empty string.

https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:68:
}
Instead of adding separate stylesheets just set the inline style of the
elements, check if doing this removes the need for testId entirely.

https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:77:
var content = document.createElement("div");
Stick with single quotes in this file for consistency.

https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:114:
this.tests.forEach(function(test) {
Assert that samples and instances are the same length.

https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:138:
assertAnimationsRunningOnCompositorThread() {
assertAnimationCompositedState() since we could be asserting that they're not
composited.

https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:142:
if (composited != !this.disableThreadedAnimation)
This is very confusing to read. If we rename this.disableThreadedAnimation to
this.composited it would be much clearer.

https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:157:
}
Can we use requestAnimationFrame instead? We should try to make these tests work
with "content_shell --expose-internals-for-testing".

https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:200:
for (var i=0; i<=n; i++) {
Spaces around binary operators.

https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/animations/resources/composited-animations-data/rotate-zero-degrees.js
(right):

https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/resources/composited-animations-data/rotate-zero-degrees.js:6:
style: `background: magenta; margin: 5px;`,
No need for backtick string notation here and below.

https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/resources/composited-animations-data/rotate-zero-degrees.js:60:
style: `background: blue; margin: 5px;`,
margin: 5px; appears in every instance.
I would consider making the interface to be something like:
var testSuite = {
  style: 'margin: 5px;',
  tests: {
    testA: {
      keyframes: ...,
      style: ...,
      fractions: ...,
    },
    ...
  },
};

This allows you to include the test name on the test instances for easier
debugging and doesn't require each test name to be typed a second time in a test
list.

https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/animations/resources/composited-animations-data/simple.js
(right):

https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/animations/resources/composited-animations-data/simple.js:7:
samples: [
Is it necessary to wrap the fraction in {at:}?
Can this just be "fractions: [0, 0.15, ...]"?

https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-animations-translate-rotate-scale.html
(right):

https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-animations-translate-rotate-scale.html:9:
test.run();
Can we simplify this to just
runCompositedAnimationTests(translateRotateScaleTests) and
runCompositedAnimationTestExpectations(translateRotateScaleTests) for the
expected file?

[Ian Vollick, 2015-09-30 21:38:36]

On 2015/09/30 01:45:28, alancutter wrote:
>
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
> File
>
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js
> (right):
> 
>
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:7:
> this.next_sample_id = 1;
> Use camel cased variable names.
> It's not clear what a sample is, can this be named nextInstanceId instead?
> 
>
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:32:
> }`;
> Can't these be part of the same stylesheet?
> 
>
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:46:
> document.body.appendChild(wrapper);
> We shouldn't rely on the automatic element id global variable for elements
> created from Javascript since we already have the handle to them in our
current
> context. Just add them as members.
> 
>
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:52:
> this.tests.forEach(function(test) {
> Use fat arrow notation so you don't have to .bind(this) everywhere.
> Alternatively just use for-of instead of forEach.
> 
>
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:59:
> styleForSamples.type = 'text/css';
> No need to set type.
> 
>
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:60:
> styleForSamples.textContent = '.test' + testId + ' {' + test.data.style + '}';
> Nit, this would be a suitable place to use backtick notation for embedded
> expressions.
> 
>
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:63:
> if (test.data.markerStyle && test.data.markerStyle != '') {
> No need to check for empty string.
> 
>
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:68:
> }
> Instead of adding separate stylesheets just set the inline style of the
> elements, check if doing this removes the need for testId entirely.
> 
>
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:77:
> var content = document.createElement("div");
> Stick with single quotes in this file for consistency.
> 
>
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:114:
> this.tests.forEach(function(test) {
> Assert that samples and instances are the same length.
> 
>
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:138:
> assertAnimationsRunningOnCompositorThread() {
> assertAnimationCompositedState() since we could be asserting that they're not
> composited.
> 
>
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:142:
> if (composited != !this.disableThreadedAnimation)
> This is very confusing to read. If we rename this.disableThreadedAnimation to
> this.composited it would be much clearer.
> 
>
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:157:
> }
> Can we use requestAnimationFrame instead? We should try to make these tests
work
> with "content_shell --expose-internals-for-testing".
> 
>
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:200:
> for (var i=0; i<=n; i++) {
> Spaces around binary operators.
> 
>
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
> File
>
third_party/WebKit/LayoutTests/animations/resources/composited-animations-data/rotate-zero-degrees.js
> (right):
> 
>
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/animations/resources/composited-animations-data/rotate-zero-degrees.js:6:
> style: `background: magenta; margin: 5px;`,
> No need for backtick string notation here and below.
> 
>
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/animations/resources/composited-animations-data/rotate-zero-degrees.js:60:
> style: `background: blue; margin: 5px;`,
> margin: 5px; appears in every instance.
> I would consider making the interface to be something like:
> var testSuite = {
>   style: 'margin: 5px;',
>   tests: {
>     testA: {
>       keyframes: ...,
>       style: ...,
>       fractions: ...,
>     },
>     ...
>   },
> };
> 
> This allows you to include the test name on the test instances for easier
> debugging and doesn't require each test name to be typed a second time in a
test
> list.
> 
>
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
> File
>
third_party/WebKit/LayoutTests/animations/resources/composited-animations-data/simple.js
> (right):
> 
>
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/animations/resources/composited-animations-data/simple.js:7:
> samples: [
> Is it necessary to wrap the fraction in {at:}?
> Can this just be "fractions: [0, 0.15, ...]"?
> 
>
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
> File
>
third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-animations-translate-rotate-scale.html
> (right):
> 
>
https://codereview.chromium.org/1360233004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-animations-translate-rotate-scale.html:9:
> test.run();
> Can we simplify this to just
> runCompositedAnimationTests(translateRotateScaleTests) and
> runCompositedAnimationTestExpectations(translateRotateScaleTests) for the
> expected file?

Whoops - I'd missed that you migrated the change to a different issue. This
approach seems fine to me, but I defer to Alan and Doug for the details.

[loyso (OOO), 2015-10-06 01:47:50]

https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/L...
File
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js
(right):

https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/L...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:7:
this.next_sample_id = 1;
On 2015/09/30 01:45:27, alancutter wrote:
> Use camel cased variable names.
> It's not clear what a sample is, can this be named nextInstanceId instead?

Done.

https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/L...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:32:
}`;
On 2015/09/30 01:45:27, alancutter wrote:
> Can't these be part of the same stylesheet?

Done.

https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/L...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:46:
document.body.appendChild(wrapper);
On 2015/09/30 01:45:27, alancutter wrote:
> We shouldn't rely on the automatic element id global variable for elements
> created from Javascript since we already have the handle to them in our
current
> context. Just add them as members.

Done.

https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/L...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:52:
this.tests.forEach(function(test) {
On 2015/09/30 01:45:27, alancutter wrote:
> Use fat arrow notation so you don't have to .bind(this) everywhere.
> Alternatively just use for-of instead of forEach.

Done.

https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/L...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:59:
styleForSamples.type = 'text/css';
On 2015/09/30 01:45:27, alancutter wrote:
> No need to set type.

Done.

https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/L...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:60:
styleForSamples.textContent = '.test' + testId + ' {' + test.data.style + '}';
On 2015/09/30 01:45:27, alancutter wrote:
> Nit, this would be a suitable place to use backtick notation for embedded
> expressions.

Done.

https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/L...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:63:
if (test.data.markerStyle && test.data.markerStyle != '') {
On 2015/09/30 01:45:27, alancutter wrote:
> No need to check for empty string.
Done.

https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/L...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:68:
}
On 2015/09/30 01:45:27, alancutter wrote:
> Instead of adding separate stylesheets just set the inline style of the
> elements, check if doing this removes the need for testId entirely.

Done.

https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/L...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:77:
var content = document.createElement("div");
On 2015/09/30 01:45:27, alancutter wrote:
> Stick with single quotes in this file for consistency.

Done.

https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/L...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:114:
this.tests.forEach(function(test) {
On 2015/09/30 01:45:27, alancutter wrote:
> Assert that samples and instances are the same length.

Done.

https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/L...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:138:
assertAnimationsRunningOnCompositorThread() {
On 2015/09/30 01:45:27, alancutter wrote:
> assertAnimationCompositedState() since we could be asserting that they're not
> composited.

Done.

https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/L...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:142:
if (composited != !this.disableThreadedAnimation)
On 2015/09/30 01:45:27, alancutter wrote:
> This is very confusing to read. If we rename this.disableThreadedAnimation to
> this.composited it would be much clearer.

Done.

https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/L...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:157:
}
On 2015/09/30 01:45:27, alancutter wrote:
> Can we use requestAnimationFrame instead? We should try to make these tests
work
> with "content_shell --expose-internals-for-testing".

Done. layoutAndPaintAsyncThen implicitly posts message for
RenderWidgetCompositor::LayoutAndUpdateLayers and waits for tree activation and
drawing to happen. requestAnimationFrame works (by accident?) but I have no
explanations why. It might be fragile/flaky.

https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/L...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:200:
for (var i=0; i<=n; i++) {
On 2015/09/30 01:45:27, alancutter wrote:
> Spaces around binary operators.

Done.

https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/L...
File
third_party/WebKit/LayoutTests/animations/resources/composited-animations-data/rotate-zero-degrees.js
(right):

https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/L...
third_party/WebKit/LayoutTests/animations/resources/composited-animations-data/rotate-zero-degrees.js:6:
style: `background: magenta; margin: 5px;`,
On 2015/09/30 01:45:27, alancutter wrote:
> No need for backtick string notation here and below.

Done.

https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/L...
third_party/WebKit/LayoutTests/animations/resources/composited-animations-data/rotate-zero-degrees.js:60:
style: `background: blue; margin: 5px;`,
On 2015/09/30 01:45:27, alancutter wrote:
> margin: 5px; appears in every instance.
> I would consider making the interface to be something like:
> var testSuite = {
>   style: 'margin: 5px;',
>   tests: {
>     testA: {
>       keyframes: ...,
>       style: ...,
>       fractions: ...,
>     },
>     ...
>   },
> };
> 
> This allows you to include the test name on the test instances for easier
> debugging and doesn't require each test name to be typed a second time in a
test
> list.

Done.

https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/L...
File
third_party/WebKit/LayoutTests/animations/resources/composited-animations-data/simple.js
(right):

https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/L...
third_party/WebKit/LayoutTests/animations/resources/composited-animations-data/simple.js:7:
samples: [
On 2015/09/30 01:45:27, alancutter wrote:
> Is it necessary to wrap the fraction in {at:}?
> Can this just be "fractions: [0, 0.15, ...]"?
I want to keep it extensible (we have more Manual Tests to automate), so we can
add extra properties to individual samples.
(dstockwell@ coined "samples" BTW)

https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/L...
File
third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-animations-translate-rotate-scale.html
(right):

https://chromiumcodereview.appspot.com/1360233004/diff/1/third_party/WebKit/L...
third_party/WebKit/LayoutTests/virtual/threaded/animations/composited-animations-translate-rotate-scale.html:9:
test.run();
On 2015/09/30 01:45:28, alancutter wrote:
> Can we simplify this to just
> runCompositedAnimationTests(translateRotateScaleTests) and
> runCompositedAnimationTestExpectations(translateRotateScaleTests) for the
> expected file?

Done.

[alancutter (OOO until 2018), 2015-10-06 03:42:49]

lgtm with nits.

https://codereview.chromium.org/1360233004/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js
(right):

https://codereview.chromium.org/1360233004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:44:
var testId = 1;
This is unused.

https://codereview.chromium.org/1360233004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:58:
content.setAttribute('style', test.data.markerStyle);
I've heard we have invalidation issues with setting the style attribute like
this.
I would set content.style.cssText instead to be safe.

https://codereview.chromium.org/1360233004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:71:
element.setAttribute('style', elementStyle);
Ditto.

https://codereview.chromium.org/1360233004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:86:
testId++;
This is unused.

[loyso (OOO), 2015-10-06 04:01:33]

https://chromiumcodereview.appspot.com/1360233004/diff/20001/third_party/WebK...
File
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js
(right):

https://chromiumcodereview.appspot.com/1360233004/diff/20001/third_party/WebK...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:44:
var testId = 1;
On 2015/10/06 03:42:49, alancutter wrote:
> This is unused.

Done.

https://chromiumcodereview.appspot.com/1360233004/diff/20001/third_party/WebK...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:58:
content.setAttribute('style', test.data.markerStyle);
On 2015/10/06 03:42:49, alancutter wrote:
> I've heard we have invalidation issues with setting the style attribute like
> this.
> I would set content.style.cssText instead to be safe.

Done.

https://chromiumcodereview.appspot.com/1360233004/diff/20001/third_party/WebK...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:71:
element.setAttribute('style', elementStyle);
On 2015/10/06 03:42:49, alancutter wrote:
> Ditto.

Done.

https://chromiumcodereview.appspot.com/1360233004/diff/20001/third_party/WebK...
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js:86:
testId++;
On 2015/10/06 03:42:49, alancutter wrote:
> This is unused.

Done.

[loyso (OOO), 2015-10-06 04:58:16]

The CQ bit was checked by loyso@chromium.org

[loyso (OOO), 2015-10-06 04:58:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1360233004/#ps40001
(title: "Clean up.")

[commit-bot: I haz the power, 2015-10-06 04:58:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1360233004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1360233004/40001

[commit-bot: I haz the power, 2015-10-06 05:03:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-06 05:04:26]

Patchset 3 (id:??) landed as
https://crrev.com/fabe15e0f2bb2ae79e93b69828733018f5c41402
Cr-Commit-Position: refs/heads/master@{#352539}