Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4125)

Unified Diff: chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.h

Issue 1360153003: Improve logging for PermissionRequestCreatorApiary errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.h
diff --git a/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.h b/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.h
index 074a6b7ec8e16c063d94181decfdaa38cc9d4475..4fc6cfac0b3e96064e1a702c7e564077d9dd2daf 100644
--- a/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.h
+++ b/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.h
@@ -49,7 +49,7 @@ class PermissionRequestCreatorApiary : public PermissionRequestCreator,
private:
struct Request;
- typedef ScopedVector<Request>::iterator RequestIterator;
+ using RequestIterator = ScopedVector<Request>::iterator;
// OAuth2TokenService::Consumer implementation:
void OnGetTokenSuccess(const OAuth2TokenService::Request* request,
@@ -72,9 +72,7 @@ class PermissionRequestCreatorApiary : public PermissionRequestCreator,
// we restart when the returned access token has expired.
void StartFetching(Request* request);
- void DispatchNetworkError(RequestIterator it, int error_code);
- void DispatchGoogleServiceAuthError(RequestIterator it,
- const GoogleServiceAuthError& error);
+ void DispatchResult(RequestIterator it, bool succss);
Marc Treib 2015/09/23 14:23:31 nit: succEss
Bernhard Bauer 2015/09/23 15:10:03 Yssss.
OAuth2TokenService* oauth2_token_service_;
std::string account_id_;

Powered by Google App Engine
This is Rietveld 408576698