Improve logging for PermissionRequestCreatorApiary errors.

chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SUPERVISED_USER_CHILD_ACCOUNTS_PERMISSION_REQUEST_CREATOR_APIARY_H_
 #define CHROME_BROWSER_SUPERVISED_USER_CHILD_ACCOUNTS_PERMISSION_REQUEST_CREATOR_APIARY_H_
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
@@ skipping 31 matching lines @@
   bool IsEnabled() const override;
   void CreateURLAccessRequest(const GURL& url_requested,
                               const SuccessCallback& callback) override;
   void CreateExtensionUpdateRequest(const std::string& id,
                                     const SuccessCallback& callback) override;
 
   void set_url_fetcher_id_for_testing(int id) { url_fetcher_id_ = id; }
 
  private:
   struct Request;
-  typedef ScopedVector<Request>::iterator RequestIterator;
+  using RequestIterator = ScopedVector<Request>::iterator;
 
   // OAuth2TokenService::Consumer implementation:
   void OnGetTokenSuccess(const OAuth2TokenService::Request* request,
                          const std::string& access_token,
                          const base::Time& expiration_time) override;
   void OnGetTokenFailure(const OAuth2TokenService::Request* request,
                          const GoogleServiceAuthError& error) override;
 
   // net::URLFetcherDelegate implementation.
   void OnURLFetchComplete(const net::URLFetcher* source) override;
 
   GURL GetApiUrl() const;
   std::string GetApiScope() const;
 
   void CreateRequest(const std::string& request_type,
                      const std::string& object_ref,
                      const SuccessCallback& callback);
 
   // Requests an access token, which is the first thing we need. This is where
   // we restart when the returned access token has expired.
   void StartFetching(Request* request);
 
-  void DispatchNetworkError(RequestIterator it, int error_code);
-  void DispatchGoogleServiceAuthError(RequestIterator it,
-                                      const GoogleServiceAuthError& error);
+  void DispatchResult(RequestIterator it, bool succss);

[Marc Treib, 2015/09/23 14:23:31]

nit: succEss

[Bernhard Bauer, 2015/09/23 15:10:03]

Yssss.

 
   OAuth2TokenService* oauth2_token_service_;
   std::string account_id_;
   net::URLRequestContextGetter* context_;
   int url_fetcher_id_;
 
   ScopedVector<Request> requests_;
 
   DISALLOW_COPY_AND_ASSIGN(PermissionRequestCreatorApiary);
 };
 
 #endif  // CHROME_BROWSER_SUPERVISED_USER_CHILD_ACCOUNTS_PERMISSION_REQUEST_CREATOR_APIARY_H_