Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1360153003: Improve logging for PermissionRequestCreatorApiary errors. (Closed)

Created:
5 years, 3 months ago by Bernhard Bauer
Modified:
5 years, 2 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, pam+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve logging for PermissionRequestCreatorApiary errors. BUG=535125 Committed: https://crrev.com/7bfff22f81b9563976045b54f372595754292bf8 Cr-Commit-Position: refs/heads/master@{#351123}

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 4

Patch Set 3 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -26 lines) Patch
M chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.h View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc View 1 2 5 chunks +15 lines, -22 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Bernhard Bauer
Please review.
5 years, 2 months ago (2015-09-23 14:19:51 UTC) #2
Marc Treib
lgtm https://codereview.chromium.org/1360153003/diff/20001/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc File chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc (right): https://codereview.chromium.org/1360153003/diff/20001/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc#newcode264 chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc:264: LOG(WARNING) << "Key not found"; s/Key/ID/g https://codereview.chromium.org/1360153003/diff/20001/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.h File ...
5 years, 2 months ago (2015-09-23 14:23:31 UTC) #3
Bernhard Bauer
https://codereview.chromium.org/1360153003/diff/20001/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc File chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc (right): https://codereview.chromium.org/1360153003/diff/20001/chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc#newcode264 chrome/browser/supervised_user/child_accounts/permission_request_creator_apiary.cc:264: LOG(WARNING) << "Key not found"; On 2015/09/23 14:23:31, Marc ...
5 years, 2 months ago (2015-09-23 15:10:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360153003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360153003/40001
5 years, 2 months ago (2015-09-23 15:10:49 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/124500)
5 years, 2 months ago (2015-09-23 15:37:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360153003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360153003/40001
5 years, 2 months ago (2015-09-23 16:26:30 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/56516)
5 years, 2 months ago (2015-09-23 17:05:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360153003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360153003/40001
5 years, 2 months ago (2015-09-28 18:42:55 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-28 19:42:05 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 19:42:52 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/7bfff22f81b9563976045b54f372595754292bf8
Cr-Commit-Position: refs/heads/master@{#351123}

Powered by Google App Engine
This is Rietveld 408576698