content/public/renderer/render_frame.h - Issue 1360123006: Introduce RenderFrame::IsMainFrame and clean up a few things.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/renderer/render_frame.h

Issue 1360123006: Introduce RenderFrame::IsMainFrame and clean up a few things. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed content_browsertests failure. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/chrome_content_renderer_client.cc ('K') | « content/public/renderer/content_renderer_client.h ('k') | content/renderer/render_frame_impl.h » ('j') | content/renderer/render_frame_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/renderer/render_frame.h

diff --git a/content/public/renderer/render_frame.h b/content/public/renderer/render_frame.h

index 4bb763bbeb06fda3974c6d5a101b80ce8323db33..517946aa3cbdc35164525b23102b2491499a2cdf 100644

--- a/content/public/renderer/render_frame.h

+++ b/content/public/renderer/render_frame.h

@@ -115,6 +115,10 @@ class CONTENT_EXPORT RenderFrame : public IPC::Listener,

// Execute a string of JavaScript in this frame's context.

virtual void ExecuteJavaScript(const base::string16& javascript) = 0;

+ // Returns true if this is the main frame

+ // (That's the frame at the top of the frame tree).

Charlie Reis 2015/09/26 00:08:04 nit: No need for the clarification, I think. At m

dglazkov 2015/09/28 04:03:35 Done.

+ virtual bool IsMainFrame() = 0;

// Return true if this frame is hidden.

virtual bool IsHidden() = 0;