content/public/renderer/content_renderer_client.h - Issue 1360123006: Introduce RenderFrame::IsMainFrame and clean up a few things.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/renderer/content_renderer_client.h

Issue 1360123006: Introduce RenderFrame::IsMainFrame and clean up a few things. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed content_browsertests failure. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/chrome_content_renderer_client.cc ('K') | « chrome/renderer/chrome_content_renderer_client.cc ('k') | content/public/renderer/render_frame.h » ('j') | content/public/renderer/render_frame.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/renderer/content_renderer_client.h

diff --git a/content/public/renderer/content_renderer_client.h b/content/public/renderer/content_renderer_client.h

index 0e0592900fd76697bc5d51ca68d470218b0f5c88..7cf06672239cbc1b2823159ed1c4abf539cf8c1b 100644

--- a/content/public/renderer/content_renderer_client.h

+++ b/content/public/renderer/content_renderer_client.h

@@ -76,9 +76,7 @@ class CONTENT_EXPORT ContentRendererClient {

// Notifies us that the RenderThread has been created.

virtual void RenderThreadStarted() {}

- // Notifies that a new RenderFrame has been created. Note that at this point,

- // render_frame->GetWebFrame()->parent() is always NULL. This will change once

- // the frame tree moves from Blink to content.

+ // Notifies that a new RenderFrame has been created.

virtual void RenderFrameCreated(RenderFrame* render_frame) {}

// Notifies that a new RenderView has been created.