Issue 13601016: Fixed apps v2 patch w.r.t. settings migration.

Issue 13601016: Fixed apps v2 patch w.r.t. settings migration. (Closed)

Created:
7 years, 8 months ago by Jamie

Modified:
7 years, 8 months ago

Reviewers:
Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed apps v2 patch w.r.t. settings migration. Apps v2 can't access window.localStorage, so the settings migration code throws an exception under apps v2. BUG=226488, 134213 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192679

Patch Set 1 #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -4 lines)			Patch
	M	remoting/webapp/appsv2.patch	View		4 chunks	+13 lines, -4 lines	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Wez

https://codereview.chromium.org/13601016/diff/1/remoting/webapp/appsv2.patch File remoting/webapp/appsv2.patch (right): https://codereview.chromium.org/13601016/diff/1/remoting/webapp/appsv2.patch#newcode119 remoting/webapp/appsv2.patch:119: remoting.initMockStorage(); Do we still need mock storage, now we're ...

7 years, 8 months ago (2013-04-05 18:47:30 UTC) #2

Jamie

7 years, 8 months ago (2013-04-05 18:54:13 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/13601016/1

7 years, 8 months ago (2013-04-05 22:45:31 UTC) #5

Message was sent while issue was closed.

Change committed as 192679

Expand Messages | Collapse Messages