Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: remoting/webapp/appsv2.patch

Issue 13601016: Fixed apps v2 patch w.r.t. settings migration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 diff --git a/remoting/webapp/event_handlers.js b/remoting/webapp/event_handlers. js 1 diff --git a/remoting/webapp/event_handlers.js b/remoting/webapp/event_handlers. js
2 index 5dfc368..f69d984 100644 2 index 5dfc368..f69d984 100644
3 --- a/event_handlers.js 3 --- a/event_handlers.js
4 +++ b/event_handlers.js 4 +++ b/event_handlers.js
5 @@ -54,7 +54,6 @@ function onLoad() { 5 @@ -54,7 +54,6 @@ function onLoad() {
6 fn: remoting.sendCtrlAltDel }, 6 fn: remoting.sendCtrlAltDel },
7 { event: 'click', id: 'send-print-screen', 7 { event: 'click', id: 'send-print-screen',
8 fn: remoting.sendPrintScreen }, 8 fn: remoting.sendPrintScreen },
9 - { event: 'click', id: 'auth-button', fn: doAuthRedirect }, 9 - { event: 'click', id: 'auth-button', fn: doAuthRedirect },
10 { event: 'click', id: 'share-button', fn: remoting.tryShare }, 10 { event: 'click', id: 'share-button', fn: remoting.tryShare },
11 { event: 'click', id: 'access-mode-button', fn: goEnterAccessCode }, 11 { event: 'click', id: 'access-mode-button', fn: goEnterAccessCode },
12 { event: 'click', id: 'cancel-share-button', fn: remoting.cancelShare }, 12 { event: 'click', id: 'cancel-share-button', fn: remoting.cancelShare },
13 @@ -104,6 +103,4 @@ function onBeforeUnload() { 13 @@ -104,6 +103,4 @@ function onBeforeUnload() {
14 } 14 }
15 15
16 window.addEventListener('load', onLoad, false); 16 window.addEventListener('load', onLoad, false);
17 -window.addEventListener('beforeunload', onBeforeUnload, false); 17 -window.addEventListener('beforeunload', onBeforeUnload, false);
18 window.addEventListener('resize', remoting.onResize, false); 18 window.addEventListener('resize', remoting.onResize, false);
19 -window.addEventListener('unload', remoting.disconnect, false); 19 -window.addEventListener('unload', remoting.disconnect, false);
20 diff --git a/remoting/webapp/host_controller.js b/remoting/webapp/host_controlle r.js 20 diff --git a/remoting/webapp/host_controller.js b/remoting/webapp/host_controlle r.js
21 index 83c9844..98f63c3 100644 21 index 83c9844..98f63c3 100644
22 --- a/host_controller.js 22 --- a/host_controller.js
23 +++ b/host_controller.js 23 +++ b/host_controller.js
24 @@ -351,7 +351,7 @@ remoting.HostController.prototype.getLocalHostStateAndId = f unction(onDone) { 24 @@ -356,7 +356,7 @@ remoting.HostController.prototype.getLocalHostStateAndId = f unction(onDone) {
25 onDone(hostId); 25 onDone(hostId);
26 }; 26 };
27 try { 27 try {
28 - this.plugin_.getDaemonConfig(onConfig); 28 - this.plugin_.getDaemonConfig(onConfig);
29 + onConfig('{}'); 29 + onConfig('{}');
30 } catch (err) { 30 } catch (err) {
31 onDone(null); 31 onDone(null);
32 } 32 }
33 diff --git a/remoting/webapp/main.html b/remoting/webapp/main.html 33 diff --git a/remoting/webapp/main.html b/remoting/webapp/main.html
34 index 061caeb..f61e532 100644 34 index 061caeb..f61e532 100644
35 --- a/main.html 35 --- a/main.html
36 +++ b/main.html 36 +++ b/main.html
37 @@ -34,6 +34,7 @@ found in the LICENSE file. 37 @@ -35,6 +35,7 @@ found in the LICENSE file.
38 <script src="host_settings.js"></script> 38 <script src="host_settings.js"></script>
39 <script src="host_setup_dialog.js"></script> 39 <script src="host_setup_dialog.js"></script>
40 <script src="host_table_entry.js"></script> 40 <script src="host_table_entry.js"></script>
41 + <script src="identity.js"></script> 41 + <script src="identity.js"></script>
42 <script src="l10n.js"></script> 42 <script src="l10n.js"></script>
43 <script src="log_to_server.js"></script> 43 <script src="log_to_server.js"></script>
44 <script src="menu_button.js"></script> 44 <script src="menu_button.js"></script>
45 diff --git a/remoting/webapp/manifest.json b/remoting/webapp/manifest.json 45 diff --git a/remoting/webapp/manifest.json b/remoting/webapp/manifest.json
46 index 5be9243..39052b9 100644 46 index 5be9243..39052b9 100644
47 --- a/manifest.json 47 --- a/manifest.json
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 } 101 }
102 + }, 102 + },
103 + "sandbox": { 103 + "sandbox": {
104 + "pages": [ "wcs_sandbox.html" ] 104 + "pages": [ "wcs_sandbox.html" ]
105 } 105 }
106 } 106 }
107 diff --git a/remoting/webapp/remoting.js b/remoting/webapp/remoting.js 107 diff --git a/remoting/webapp/remoting.js b/remoting/webapp/remoting.js
108 index f89072a..2fadd83 100644 108 index f89072a..2fadd83 100644
109 --- a/remoting.js 109 --- a/remoting.js
110 +++ b/remoting.js 110 +++ b/remoting.js
111 @@ -43,10 +43,7 @@ remoting.init = function() { 111 @@ -34,8 +34,6 @@ function consentRequired_(authContinue) {
112 * Entry point for app initialization.
113 */
114 remoting.init = function() {
115 - migrateLocalToChromeStorage_();
116 -
117 // TODO(jamiewalch): Remove this when we migrate to apps v2
118 // (http://crbug.com/ 134213).
119 remoting.initMockStorage();
Wez 2013/04/05 18:47:30 Do we still need mock storage, now we're on chrome
Jamie 2013/04/05 18:54:14 No. There's a separate bug to remove it (http://cr
120 @@ -45,10 +45,7 @@ remoting.init = function() {
112 // Create global objects. 121 // Create global objects.
113 remoting.settings = new remoting.Settings(); 122 remoting.settings = new remoting.Settings();
114 remoting.oauth2 = new remoting.OAuth2(); 123 remoting.oauth2 = new remoting.OAuth2();
115 - // TODO(jamiewalch): Reinstate this when we migrate to apps v2 124 - // TODO(jamiewalch): Reinstate this when we migrate to apps v2
116 - // (http://crbug.com/ 134213). 125 - // (http://crbug.com/ 134213).
117 - // remoting.identity = new remoting.Identity(consentRequired_); 126 - // remoting.identity = new remoting.Identity(consentRequired_);
118 - remoting.identity = remoting.oauth2; 127 - remoting.identity = remoting.oauth2;
119 + remoting.identity = new remoting.Identity(consentRequired_); 128 + remoting.identity = new remoting.Identity(consentRequired_);
120 remoting.stats = new remoting.ConnectionStats( 129 remoting.stats = new remoting.ConnectionStats(
121 document.getElementById('statistics')); 130 document.getElementById('statistics'));
122 remoting.formatIq = new remoting.FormatIq(); 131 remoting.formatIq = new remoting.FormatIq();
123 @@ -131,9 +128,6 @@ remoting.initHomeScreenUi = function () { 132 @@ -133,9 +130,6 @@ remoting.initHomeScreenUi = function () {
124 document.getElementById('share-button').disabled = 133 document.getElementById('share-button').disabled =
125 !remoting.hostController.isPluginSupported(); 134 !remoting.hostController.isPluginSupported();
126 remoting.setMode(remoting.AppMode.HOME); 135 remoting.setMode(remoting.AppMode.HOME);
127 - if (!remoting.oauth2.isAuthenticated()) { 136 - if (!remoting.oauth2.isAuthenticated()) {
128 - document.getElementById('auth-dialog').hidden = false; 137 - document.getElementById('auth-dialog').hidden = false;
129 - } 138 - }
130 remoting.hostSetupDialog = 139 remoting.hostSetupDialog =
131 new remoting.HostSetupDialog(remoting.hostController); 140 new remoting.HostSetupDialog(remoting.hostController);
132 // Display the cached host list, then asynchronously update and re-display it . 141 // Display the cached host list, then asynchronously update and re-display it .
133 diff --git a/remoting/webapp/xhr_proxy.js b/remoting/webapp/xhr_proxy.js 142 diff --git a/remoting/webapp/xhr_proxy.js b/remoting/webapp/xhr_proxy.js
134 index 4c45780..653b481 100644 143 index 4c45780..653b481 100644
135 --- a/xhr_proxy.js 144 --- a/xhr_proxy.js
136 +++ b/xhr_proxy.js 145 +++ b/xhr_proxy.js
137 @@ -90,4 +90,4 @@ remoting.XMLHttpRequestProxy.prototype.DONE = 4; 146 @@ -90,4 +90,4 @@ remoting.XMLHttpRequestProxy.prototype.DONE = 4;
138 147
139 // Since the WCS driver code constructs XHRs directly, the only mechanism for 148 // Since the WCS driver code constructs XHRs directly, the only mechanism for
140 // proxying them is to replace the XMLHttpRequest constructor. 149 // proxying them is to replace the XMLHttpRequest constructor.
141 -//XMLHttpRequest = remoting.XMLHttpRequestProxy; 150 -//XMLHttpRequest = remoting.XMLHttpRequestProxy;
142 +XMLHttpRequest = remoting.XMLHttpRequestProxy; 151 +XMLHttpRequest = remoting.XMLHttpRequestProxy;
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698