Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1360023003: MediaStreamRemoteVideoSource: Remove dependency to cricket::VideoFrame::GetElapsedTime() (Closed)

Created:
5 years, 3 months ago by magjed_chromium
Modified:
5 years, 2 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MediaStreamRemoteVideoSource: Remove dependency to cricket::VideoFrame::GetElapsedTime() The purpose with this CL is to remove the last use of cricket::VideoFrame::GetElapsedTime() so we can remove it, see: https://codereview.webrtc.org/1324263004/ Committed: https://crrev.com/f25569ff7c510367b0083ff54ba263c7b456ab87 Cr-Commit-Position: refs/heads/master@{#350814}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Check that incoming timestamp is never kNoTimestamp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -17 lines) Patch
M content/renderer/media/webrtc/media_stream_remote_video_source.cc View 1 4 chunks +24 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
magjed_chromium
tommi - Please take a look.
5 years, 2 months ago (2015-09-25 07:13:18 UTC) #2
tommi (sloooow) - chröme
Lgtm. One question https://codereview.chromium.org/1360023003/diff/1/content/renderer/media/webrtc/media_stream_remote_video_source.cc File content/renderer/media/webrtc/media_stream_remote_video_source.cc (right): https://codereview.chromium.org/1360023003/diff/1/content/renderer/media/webrtc/media_stream_remote_video_source.cc#newcode65 content/renderer/media/webrtc/media_stream_remote_video_source.cc:65: start_timestamp_(media::kNoTimestamp()), Is kNoTimestamp a function?
5 years, 2 months ago (2015-09-25 07:53:50 UTC) #3
magjed_chromium
https://codereview.chromium.org/1360023003/diff/1/content/renderer/media/webrtc/media_stream_remote_video_source.cc File content/renderer/media/webrtc/media_stream_remote_video_source.cc (right): https://codereview.chromium.org/1360023003/diff/1/content/renderer/media/webrtc/media_stream_remote_video_source.cc#newcode65 content/renderer/media/webrtc/media_stream_remote_video_source.cc:65: start_timestamp_(media::kNoTimestamp()), On 2015/09/25 07:53:50, tommi wrote: > Is kNoTimestamp ...
5 years, 2 months ago (2015-09-25 08:21:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1360023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1360023003/20001
5 years, 2 months ago (2015-09-25 12:21:35 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-25 13:28:25 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 13:30:50 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f25569ff7c510367b0083ff54ba263c7b456ab87
Cr-Commit-Position: refs/heads/master@{#350814}

Powered by Google App Engine
This is Rietveld 408576698