Issue 1359963003: Fix minor bug in ParseIndexColumn

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1359963003: Fix minor bug in ParseIndexColumn (Closed)

Created:
5 years, 3 months ago by iannucci

Modified:
5 years, 3 months ago

Reviewers:
dnj, Vadim Sh., estaab, M-A Ruel, tandrii(chromium)

CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org

Base URL:
https://github.com/luci/gae.git@master

Target Ref:
refs/heads/master

Project:
luci-gae

Visibility:
Public.

More Reviews

Description

Fix minor bug in ParseIndexColumn Also improve error message. R=dnj@chromium.org, estaab@chromium.org, maruel@chromium.org, tandrii@chromium.org, vadimsh@chromium.org BUG= Committed: https://github.com/luci/gae/commit/cbf69cbb75d6814e47d01f4a4484c84d72d59b21

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	service/datastore/index.go	View		2 chunks	+2 lines, -1 line	0 comments	Download

Dependent Patchsets:

Issue 1363063002 Patch 1

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

iannucci

On 2015/09/22 at 22:49:53, vadimsh wrote: > lgtm > > what about regression test? ;) ...

5 years, 3 months ago (2015-09-22 22:52:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359963003/1

5 years, 3 months ago (2015-09-22 22:52:25 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-09-22 22:55:16 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/cbf69cbb75d6814e47d01f4a4484c84d72d59b21

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages