Add ability to estimate the size of a PropertyMap

Add ability to estimate the size of a PropertyMap

This will be used to track in-flight transaction sizes.

R=dnj@chromium.org, estaab@chromium.org, maruel@chromium.org, tandrii@chromium.org, vadimsh@chromium.org
BUG=533021
Committed: https://github.com/luci/gae/commit/362a439e09ed815a83b82a61b96499a8ab565241

[Vadim Sh., 2015-09-23 20:02:54]

lgtm

[dnj (Google), 2015-09-23 20:03:18]

dnj@google.com changed reviewers:
+ dnj@google.com

[dnj (Google), 2015-09-23 20:03:19]

https://codereview.chromium.org/1363063002/diff/1/service/datastore/propertie...
File service/datastore/properties.go (right):

https://codereview.chromium.org/1363063002/diff/1/service/datastore/propertie...
service/datastore/properties.go:803: func (pm PropertyMap)
EstimateSize(withNamespace bool) int {
Accumulating int, maybe should use int64?

https://codereview.chromium.org/1363063002/diff/1/service/datastore/propertie...
service/datastore/properties.go:803: func (pm PropertyMap)
EstimateSize(withNamespace bool) int {
Why is "withNamespace" not always "true"?

[iannucci, 2015-09-23 20:28:41]

https://codereview.chromium.org/1363063002/diff/1/service/datastore/propertie...
File service/datastore/properties.go (right):

https://codereview.chromium.org/1363063002/diff/1/service/datastore/propertie...
service/datastore/properties.go:803: func (pm PropertyMap)
EstimateSize(withNamespace bool) int {
On 2015/09/23 at 20:03:19, dnj (Google) wrote:
> Why is "withNamespace" not always "true"?

good question. I looked at the doc and it seems like they're always encoded with
the namespace in the actual entity, but are duplicately encoded in the row key
but with a special prefix delta scheme (of unspecified nature).

[iannucci, 2015-09-23 21:35:31]

(ptal)

[iannucci, 2015-09-23 23:52:20]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2015-09-23 23:52:21]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/1363063002/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2015-09-23 23:52:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1363063002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1363063002/20001

[commit-bot: I haz the power, 2015-09-23 23:58:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 23:58:03]

Try jobs failed on following builders:
  Luci-GAE Presubmit on master.tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Luci-GAE%20Presubmit/bu...)

[iannucci, 2015-09-23 23:59:04]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2015-09-23 23:59:05]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/1363063002/#ps40001
(title: "fix errcheck madness")

[commit-bot: I haz the power, 2015-09-23 23:59:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1363063002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1363063002/40001

[commit-bot: I haz the power, 2015-09-24 00:00:27]

Committed patchset #3 (id:40001) as
https://github.com/luci/gae/commit/362a439e09ed815a83b82a61b96499a8ab565241