Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: public/platform/modules/background_sync/WebSyncProvider.h

Issue 1359653002: Clean up WebSyncProvider now that the browser has implemented the necessary functionality. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: abstract Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/modules/background_sync/WebSyncProvider.h
diff --git a/public/platform/modules/background_sync/WebSyncProvider.h b/public/platform/modules/background_sync/WebSyncProvider.h
index cb337a18b57f73680de012fefbe3aaf9af8b34be..7c590cb67af14a0f1f4eba5d901719ea244e403c 100644
--- a/public/platform/modules/background_sync/WebSyncProvider.h
+++ b/public/platform/modules/background_sync/WebSyncProvider.h
@@ -48,25 +48,9 @@ public:
virtual void getPermissionStatus(blink::WebSyncRegistration::Periodicity, WebServiceWorkerRegistration*, WebSyncGetPermissionStatusCallbacks*) = 0;
// Takes ownership of the WebSyncNotifyWhenDoneCallbacks.
- virtual void notifyWhenDone(int64_t syncId, WebSyncNotifyWhenDoneCallbacks* callbacks)
- {
- // TODO(jkarlin): After landing both legs of the notifyWhenDone CLs, make this a pure virtual function.
- callbacks->onError(WebSyncError(WebSyncError::ErrorTypeAbort, "Function not implemented."));
- delete callbacks;
- }
+ virtual void notifyWhenDone(int64_t syncId, WebSyncNotifyWhenDoneCallbacks*) = 0;
- // Takes ownership of the WebServiceWorkerRegistration.
- virtual void trackRegistration(WebSyncRegistration* registration)
- {
- // TODO(jkarlin): After landing both legs of the releaseRegistration CLs, make this a pure virtual function.
- return;
- }
-
- virtual void releaseRegistration(int64_t syncId)
- {
- // TODO(jkarlin): After landing both legs of the releaseRegistration CLs, make this a pure virtual function.
- return;
- }
+ virtual void releaseRegistration(int64_t syncId) = 0;
};
} // namespace blink
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698