chrome/test/base/js2gtest.gni - Issue 1359513002: Various fixes for 32-bit Linux GN builds that need to be tracked down.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/js2gtest.gni

Issue 1359513002: Various fixes for 32-bit Linux GN builds that need to be tracked down. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: share snapshot_toolchain.gni Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/base/js2gtest.gni

diff --git a/chrome/test/base/js2gtest.gni b/chrome/test/base/js2gtest.gni

index 0ae79a9d18a0067b1d05e55bfa2bb6e4bc425a13..f4b6c76e006b2f595674b5ebd89e1812ab165b22 100644

--- a/chrome/test/base/js2gtest.gni

+++ b/chrome/test/base/js2gtest.gni

@@ -3,6 +3,7 @@

# found in the LICENSE file.

import("//build/module_args/v8.gni")

+import("//v8/snapshot_toolchain.gni")

Roland McGrath 2015/09/21 23:59:07 I can't find snapshot_toolchain.gni. Is it in ano

# Variables:

# test_type: One of 'webui', 'unit' or 'extension' indicating what

@@ -34,7 +35,8 @@ template("js2gtest") {

sources = invoker.sources

- d8_path = get_label_info("//v8:d8($host_toolchain)", "root_out_dir") + "/d8"

+ d8_path =

+ get_label_info("//v8:d8($snapshot_toolchain)", "root_out_dir") + "/d8"

if (is_win) {

d8_path += ".exe"

}

@@ -85,7 +87,7 @@ template("js2gtest") {

args += rebase_path(outputs, root_build_dir)

deps = [

- "//v8:d8($host_toolchain)",

+ "//v8:d8($snapshot_toolchain)",

]

if (defined(invoker.deps)) {

deps += invoker.deps

« build/config/compiler/BUILD.gn ('K') | « chrome/installer/BUILD.gn ('k') | mojo/BUILD.gn » ('j') | no next file with comments »