Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7111)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/installer/BUILD.gn

Issue 1359513002: Various fixes for 32-bit Linux GN builds that need to be tracked down. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: share snapshot_toolchain.gni Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/compiler/BUILD.gn ('K') | « build/config/compiler/BUILD.gn ('k') | chrome/test/base/js2gtest.gni » ('j') | chrome/test/base/js2gtest.gni » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/BUILD.gn
diff --git a/chrome/installer/BUILD.gn b/chrome/installer/BUILD.gn
index fcd39969bef6d33e79ab9eaa1fca635824705ec5..d8f7fa8dbfb4724e9b062b64395f4e7218b05dfe 100644
--- a/chrome/installer/BUILD.gn
+++ b/chrome/installer/BUILD.gn
@@ -6,7 +6,8 @@ import("//build/config/chrome_build.gni")
# Meta-target that forwards to the installer of the correct type (if any).
group("installer") {
- if (is_desktop_linux && is_chrome_branded) {
+ # TODO(GYP): Get the 32-bit build to work.
+ if (is_desktop_linux && is_chrome_branded && target_cpu == "x64") {
deps = [
"//chrome/installer/linux",
]
« build/config/compiler/BUILD.gn ('K') | « build/config/compiler/BUILD.gn ('k') | chrome/test/base/js2gtest.gni » ('j') | chrome/test/base/js2gtest.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698