Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1359513002: Various fixes for 32-bit Linux GN builds that need to be tracked down. (Closed)

Created:
5 years, 3 months ago by Dirk Pranke
Modified:
5 years, 3 months ago
Reviewers:
brettw, Roland McGrath
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, grt+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, wfh+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Various fixes for 32-bit Linux GN builds that need to be tracked down. 1) 64-bit gold linking doesn't work right 2) We need to compile d8 with the 32-bit clang toolchain to run the js browser tests 3) parts of mojo depend on cython which depends on the python sdks being present in the sysroot 4) we get errors trying to build the installer R=brettw@chromium.org, mcgrathr@chromium.org BUG= Committed: https://crrev.com/e0f6a916e895a301edbf408b77068caa963cce31 Cr-Commit-Position: refs/heads/master@{#350243}

Patch Set 1 #

Patch Set 2 : fix comment #

Patch Set 3 : share snapshot_toolchain.gni #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M build/config/compiler/BUILD.gn View 1 1 chunk +4 lines, -3 lines 1 comment Download
M chrome/installer/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/base/js2gtest.gni View 1 2 3 chunks +4 lines, -2 lines 1 comment Download
M mojo/BUILD.gn View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Roland McGrath
https://codereview.chromium.org/1359513002/diff/40001/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/1359513002/diff/40001/build/config/compiler/BUILD.gn#newcode50 build/config/compiler/BUILD.gn:50: use_gold = is_linux && current_cpu == "x64" I investigated ...
5 years, 3 months ago (2015-09-21 23:59:07 UTC) #1
Dirk Pranke
On 2015/09/21 23:59:07, Roland McGrath wrote: > https://codereview.chromium.org/1359513002/diff/40001/build/config/compiler/BUILD.gn > File build/config/compiler/BUILD.gn (right): > > https://codereview.chromium.org/1359513002/diff/40001/build/config/compiler/BUILD.gn#newcode50 ...
5 years, 3 months ago (2015-09-22 01:11:44 UTC) #2
brettw
lgtm
5 years, 3 months ago (2015-09-22 05:07:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1359513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1359513002/40001
5 years, 3 months ago (2015-09-22 21:17:48 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-22 21:50:39 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 22:09:29 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e0f6a916e895a301edbf408b77068caa963cce31
Cr-Commit-Position: refs/heads/master@{#350243}

Powered by Google App Engine
This is Rietveld 408576698