Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: content/browser/compositor/buffer_queue.cc

Issue 1359423002: Disable region copy on ARM since it isn't supported (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/compositor/buffer_queue.cc
diff --git a/content/browser/compositor/buffer_queue.cc b/content/browser/compositor/buffer_queue.cc
index 4845e57916e9997020048c916e9e142fff305afc..05cf13c895ed0d34955b4b6eb11f14f5454a9a5c 100644
--- a/content/browser/compositor/buffer_queue.cc
+++ b/content/browser/compositor/buffer_queue.cc
@@ -61,12 +61,20 @@ void BufferQueue::CopyBufferDamage(int texture,
int source_texture,
const gfx::Rect& new_damage,
const gfx::Rect& old_damage) {
+ // TODO(dnicoara): Remove ARM workaround once partial swap is enabled.
+#if defined(ARCH_CPU_ARM_FAMILY)
+ gl_helper_->CopySubBufferDamage(
+ texture_target_, texture, source_texture,
+ SkRegion(SkIRect::MakeXYWH(0, 0, size_.width(), size_.height())),
danakj 2015/09/23 21:09:26 nit: if i was doing this i'd share as much code as
dnicoara 2015/09/23 21:23:13 Done.
+ SkRegion(SkIRect::MakeXYWH(0, 0, 0, 0)));
+#else
gl_helper_->CopySubBufferDamage(
texture_target_, texture, source_texture,
SkRegion(SkIRect::MakeXYWH(new_damage.x(), new_damage.y(),
danakj 2015/09/23 21:09:26 btw.. RectToSkIRect: https://code.google.com/p/chr
dnicoara 2015/09/23 21:23:13 Done. Nice, forgot about the helpers.
new_damage.width(), new_damage.height())),
SkRegion(SkIRect::MakeXYWH(old_damage.x(), old_damage.y(),
old_damage.width(), old_damage.height())));
+#endif
}
void BufferQueue::UpdateBufferDamage(const gfx::Rect& damage) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698