Disable region copy on ARM since it isn't supported

content/browser/compositor/buffer_queue.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/compositor/buffer_queue.h"
 
 #include "content/browser/compositor/image_transport_factory.h"
 #include "content/browser/gpu/browser_gpu_memory_buffer_manager.h"
 #include "content/common/gpu/client/context_provider_command_buffer.h"
 #include "content/common/gpu/client/gl_helper.h"
@@ skipping 43 matching lines @@
     current_surface_ = GetNextSurface();
     gl->FramebufferTexture2D(GL_FRAMEBUFFER, GL_COLOR_ATTACHMENT0,
                              texture_target_, current_surface_.texture, 0);
   }
 }
 
 void BufferQueue::CopyBufferDamage(int texture,
                                    int source_texture,
                                    const gfx::Rect& new_damage,
                                    const gfx::Rect& old_damage) {
+  // TODO(dnicoara): Remove ARM workaround once partial swap is enabled.
+#if defined(ARCH_CPU_ARM_FAMILY)
+  gl_helper_->CopySubBufferDamage(
+      texture_target_, texture, source_texture,
+      SkRegion(SkIRect::MakeXYWH(0, 0, size_.width(), size_.height())),

[danakj, 2015/09/23 21:09:26]

nit: if i was doing this i'd share as much code as possible. something like

gfx::Rect new_damage_mutable = new_damage;
gfx::Rect old_damage_mutable = old_damage;

#if ARCH
// TODO...
new_damage_mutable = gfx::Rect(size_);
old_damage_mutable = gfx::Rect();
#endif

[dnicoara, 2015/09/23 21:23:13]

Done.

+      SkRegion(SkIRect::MakeXYWH(0, 0, 0, 0)));
+#else
   gl_helper_->CopySubBufferDamage(
       texture_target_, texture, source_texture,
       SkRegion(SkIRect::MakeXYWH(new_damage.x(), new_damage.y(),

[danakj, 2015/09/23 21:09:26]

btw.. RectToSkIRect:
https://code.google.com/p/chromium/codesearch#chromium/src/ui/gfx/skia_util.h...

[dnicoara, 2015/09/23 21:23:13]

Done. Nice, forgot about the helpers.

                                  new_damage.width(), new_damage.height())),
       SkRegion(SkIRect::MakeXYWH(old_damage.x(), old_damage.y(),
                                  old_damage.width(), old_damage.height())));
+#endif
 }
 
 void BufferQueue::UpdateBufferDamage(const gfx::Rect& damage) {
   displayed_surface_.damage.Union(damage);
   for (size_t i = 0; i < available_surfaces_.size(); i++)
     available_surfaces_[i].damage.Union(damage);
 
   for (std::deque<AllocatedSurface>::iterator it =
            in_flight_surfaces_.begin();
        it != in_flight_surfaces_.end();
@@ skipping 154 matching lines @@
     gl->DeleteTextures(1, &texture);
     return AllocatedSurface();
   }
   allocated_count_++;
   gl->BindTexture(texture_target_, texture);
   gl->BindTexImage2DCHROMIUM(texture_target_, id);
   return AllocatedSurface(texture, id, gfx::Rect(size_));
 }
 
 }  // namespace content