Disable region copy on ARM since it isn't supported

Disable region copy on ARM since it isn't supported

Copying a buffer region isn't supported on ARM due to a driver bug.
Until support is landed we can do a full copy to make sure that the
buffers are in a consistent state.

BUG=chrome-os-partner:36554, 511446
TEST=Ran on daisy, peach_pi and rockchip to verify that the device
startup up and produces frames.

Committed: https://crrev.com/b76c26887404294611d9ab3b03913fd52d0eb289
Cr-Commit-Position: refs/heads/master@{#350376}

[dnicoara, 2015-09-23 20:38:14]

dnicoara@chromium.org changed reviewers:
+ alexst@chromium.org, danakj@chromium.org

[dnicoara, 2015-09-23 20:38:14]

PTAL

[dnicoara, 2015-09-23 20:38:29]

The CQ bit was checked by dnicoara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-23 20:39:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1359423002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1359423002/1

[danakj, 2015-09-23 21:09:26]

https://codereview.chromium.org/1359423002/diff/1/content/browser/compositor/...
File content/browser/compositor/buffer_queue.cc (right):

https://codereview.chromium.org/1359423002/diff/1/content/browser/compositor/...
content/browser/compositor/buffer_queue.cc:68: SkRegion(SkIRect::MakeXYWH(0, 0,
size_.width(), size_.height())),
nit: if i was doing this i'd share as much code as possible. something like

gfx::Rect new_damage_mutable = new_damage;
gfx::Rect old_damage_mutable = old_damage;

#if ARCH
// TODO...
new_damage_mutable = gfx::Rect(size_);
old_damage_mutable = gfx::Rect();
#endif

https://codereview.chromium.org/1359423002/diff/1/content/browser/compositor/...
content/browser/compositor/buffer_queue.cc:73:
SkRegion(SkIRect::MakeXYWH(new_damage.x(), new_damage.y(),
btw.. RectToSkIRect:
https://code.google.com/p/chromium/codesearch#chromium/src/ui/gfx/skia_util.h...

[danakj, 2015-09-23 21:09:31]

LGTM

[alexst (slow to review), 2015-09-23 21:10:59]

lgtm, modulo Dana's comments.

[dnicoara, 2015-09-23 21:23:13]

https://codereview.chromium.org/1359423002/diff/1/content/browser/compositor/...
File content/browser/compositor/buffer_queue.cc (right):

https://codereview.chromium.org/1359423002/diff/1/content/browser/compositor/...
content/browser/compositor/buffer_queue.cc:68: SkRegion(SkIRect::MakeXYWH(0, 0,
size_.width(), size_.height())),
On 2015/09/23 21:09:26, danakj wrote:
> nit: if i was doing this i'd share as much code as possible. something like
> 
> gfx::Rect new_damage_mutable = new_damage;
> gfx::Rect old_damage_mutable = old_damage;
> 
> #if ARCH
> // TODO...
> new_damage_mutable = gfx::Rect(size_);
> old_damage_mutable = gfx::Rect();
> #endif

Done.

https://codereview.chromium.org/1359423002/diff/1/content/browser/compositor/...
content/browser/compositor/buffer_queue.cc:73:
SkRegion(SkIRect::MakeXYWH(new_damage.x(), new_damage.y(),
On 2015/09/23 21:09:26, danakj wrote:
> btw.. RectToSkIRect:
>
https://code.google.com/p/chromium/codesearch#chromium/src/ui/gfx/skia_util.h...

Done. Nice, forgot about the helpers.

[dnicoara, 2015-09-23 21:23:19]

The CQ bit was checked by dnicoara@chromium.org

[dnicoara, 2015-09-23 21:23:20]

The patchset sent to the CQ was uploaded after l-g-t-m from alexst@chromium.org,
danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1359423002/#ps60001
(title: "comment")

[danakj, 2015-09-23 21:24:09]

LGTM

[commit-bot: I haz the power, 2015-09-23 21:24:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1359423002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1359423002/60001

[commit-bot: I haz the power, 2015-09-23 22:45:05]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-23 22:46:02]

Patchset 4 (id:??) landed as
https://crrev.com/b76c26887404294611d9ab3b03913fd52d0eb289
Cr-Commit-Position: refs/heads/master@{#350376}