Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 135923002: Revert 244381 "Support GU retry command in sync engine. The comm..." (Closed)

Created:
6 years, 11 months ago by Nico
Modified:
6 years, 11 months ago
Reviewers:
haitaol1
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 244381 "Support GU retry command in sync engine. The comm..." Test fails on the valgrind bot: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28tsan%29%281%29/builds/11739/steps/memory%20test%3A%20unit/logs/EphemeralAppServiceTest.RemoveOverflow EphemeralAppServiceTest.RemoveOverflow: ../../chrome/browser/apps/ephemeral_app_service_unittest.cc:83: Failure Value of: removed->first < retained->first Actual: false Expected: true > Support GU retry command in sync engine. The command specifies a delay after which syncer should issue a GU to pick up updates missed by last GU. > > BUG= > > Review URL: https://codereview.chromium.org/124083002 TBR=haitaol@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244438

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -413 lines) Patch
M trunk/src/sync/engine/download.h View 1 chunk +0 lines, -15 lines 0 comments Download
M trunk/src/sync/engine/download.cc View 2 chunks +0 lines, -40 lines 0 comments Download
M trunk/src/sync/engine/download_unittest.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M trunk/src/sync/engine/sync_scheduler_impl.h View 5 chunks +3 lines, -13 lines 0 comments Download
M trunk/src/sync/engine/sync_scheduler_impl.cc View 7 chunks +16 lines, -37 lines 0 comments Download
M trunk/src/sync/engine/sync_scheduler_unittest.cc View 12 chunks +13 lines, -109 lines 0 comments Download
M trunk/src/sync/engine/syncer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/sync/engine/syncer.cc View 2 chunks +1 line, -15 lines 0 comments Download
M trunk/src/sync/engine/syncer_proto_util.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/sync/engine/syncer_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/sync/protocol/client_commands.proto View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/sync/protocol/get_updates_caller_info.proto View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/sync/protocol/proto_enum_conversions.cc View 4 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/sync/protocol/proto_enum_conversions_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/sync/protocol/sync.proto View 1 chunk +1 line, -5 lines 0 comments Download
M trunk/src/sync/protocol/sync_enums.proto View 1 chunk +3 lines, -5 lines 0 comments Download
M trunk/src/sync/sessions/nudge_tracker.h View 3 chunks +3 lines, -15 lines 0 comments Download
M trunk/src/sync/sessions/nudge_tracker.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M trunk/src/sync/sessions/nudge_tracker_unittest.cc View 13 chunks +37 lines, -56 lines 0 comments Download
M trunk/src/sync/sessions/sync_session.h View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/sync/sessions/test_util.h View 2 chunks +5 lines, -12 lines 0 comments Download
M trunk/src/sync/sessions/test_util.cc View 3 chunks +5 lines, -12 lines 0 comments Download
M trunk/src/sync/test/engine/fake_sync_scheduler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/sync/test/engine/fake_sync_scheduler.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
6 years, 11 months ago (2014-01-12 07:18:37 UTC) #1
Nico
6 years, 11 months ago (2014-01-12 07:18:59 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r244438.

Powered by Google App Engine
This is Rietveld 408576698