Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: trunk/src/sync/engine/sync_scheduler_impl.h

Issue 135923002: Revert 244381 "Support GU retry command in sync engine. The comm..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/sync/engine/download_unittest.cc ('k') | trunk/src/sync/engine/sync_scheduler_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/sync/engine/sync_scheduler_impl.h
===================================================================
--- trunk/src/sync/engine/sync_scheduler_impl.h (revision 244437)
+++ trunk/src/sync/engine/sync_scheduler_impl.h (working copy)
@@ -89,11 +89,7 @@
virtual void OnReceivedClientInvalidationHintBufferSize(int size) OVERRIDE;
virtual void OnSyncProtocolError(
const sessions::SyncSessionSnapshot& snapshot) OVERRIDE;
- virtual void OnReceivedGuRetryDelay(const base::TimeDelta& delay) OVERRIDE;
- // Returns true if the client is currently in exponential backoff.
- bool IsBackingOff() const;
-
private:
enum JobPriority {
// Non-canary jobs respect exponential backoff.
@@ -171,9 +167,6 @@
// Invoke the Syncer to perform a poll job.
void DoPollSyncSessionJob();
- // Invoke the Syncer to perform a retry job.
- void DoRetrySyncSessionJob();
-
// Helper function to calculate poll interval.
base::TimeDelta GetPollInterval();
@@ -198,6 +191,9 @@
const base::TimeDelta& delay,
const tracked_objects::Location& nudge_location);
+ // Returns true if the client is currently in exponential backoff.
+ bool IsBackingOff() const;
+
// Helper to signal all listeners registered with |session_context_|.
void Notify(SyncEngineEvent::EventCause cause);
@@ -234,9 +230,6 @@
// Creates a session for a poll and performs the sync.
void PollTimerCallback();
- // Creates a session for a retry and performs the sync.
- void RetryTimerCallback();
-
// Returns the set of types that are enabled and not currently throttled.
ModelTypeSet GetEnabledAndUnthrottledTypes();
@@ -343,9 +336,6 @@
// to be const and alleviate threading concerns.
base::WeakPtrFactory<SyncSchedulerImpl> weak_ptr_factory_for_weak_handle_;
- // One-shot timer for scheduling GU retry according to delay set by server.
- base::OneShotTimer<SyncSchedulerImpl> retry_timer_;
-
DISALLOW_COPY_AND_ASSIGN(SyncSchedulerImpl);
};
« no previous file with comments | « trunk/src/sync/engine/download_unittest.cc ('k') | trunk/src/sync/engine/sync_scheduler_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698