Issue 135913003: Optimize getField by caching a closure generated from a specialized function kind.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 135913003: Optimize getField by caching a closure generated from a specialized function kind. (Closed)

Created:
6 years, 10 months ago by rmacnak

Modified:
6 years, 10 months ago

Reviewers:
hausner, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, kasperl

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Optimize getField by caching a closure generated from a specialized function kind.

Patch Set 1 #

Patch Set 2 : no intermediate function, also handle setters #

Patch Set 3 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+206 lines, -2 lines)			Patch
M	runtime/lib/mirrors.cc	View	1	1 chunk	+77 lines, -0 lines	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View	1	2 chunks	+29 lines, -0 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/object.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/object.cc	View	1	5 chunks	+19 lines, -1 line	0 comments	Download
M	runtime/vm/parser.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2	2 chunks	+72 lines, -0 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

rmacnak

6 years, 10 months ago (2014-02-03 19:25:11 UTC) #1

Baseline    4960
Eval         499
Specialized  482

Smaller is better.


Eval
https://codereview.chromium.org/144383007/

Specialized
https://codereview.chromium.org/135913003/

Expand Messages | Collapse Messages