Optimize getField by caching a closure generated from a specialized function kind.

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/cpu.h"
@@ skipping 4725 matching lines @@
       break;
     case RawFunction::kMethodExtractor:
       return "kMethodExtractor";
       break;
     case RawFunction::kNoSuchMethodDispatcher:
       return "kNoSuchMethodDispatcher";
       break;
     case RawFunction::kInvokeFieldDispatcher:
       return "kInvokeFieldDispatcher";
       break;
+    case RawFunction::kGetFieldClosure:
+      return "kGetFieldClosure";
+      break;
+    case RawFunction::kSetFieldClosure:
+      return "kSetFieldClosure";
+      break;
     default:
       UNREACHABLE();
       return NULL;
   }
 }
 
 
 void Function::SetRedirectionType(const Type& type) const {
   ASSERT(IsFactory());
   Object& obj = Object::Handle(raw_ptr()->data_);
@@ skipping 272 matching lines @@
   if (kind() == RawFunction::kConstructor) {
     if (is_static()) {
       ASSERT(IsFactory());
       return 1;  // Type arguments.
     } else {
       ASSERT(IsConstructor());
       return 2;  // Instance, phase.
     }
   }
   if ((kind() == RawFunction::kClosureFunction) ||
+      (kind() == RawFunction::kGetFieldClosure) ||
+      (kind() == RawFunction::kSetFieldClosure) ||
       (kind() == RawFunction::kSignatureFunction)) {
     return 1;  // Closure object.
   }
   if (!is_static()) {
     // Closure functions defined inside instance (i.e. non-static) functions are
     // marked as non-static, but they do not have a receiver.
     // Closures are handled above.
     ASSERT((kind() != RawFunction::kClosureFunction) &&
+           (kind() != RawFunction::kGetFieldClosure) &&
+           (kind() != RawFunction::kSetFieldClosure) &&
            (kind() != RawFunction::kSignatureFunction));
     return 1;  // Receiver.
   }
   return 0;  // No implicit parameters.
 }
 
 
 bool Function::AreValidArgumentCounts(intptr_t num_arguments,
                                       intptr_t num_named_arguments,
                                       String* error_message) const {
@@ skipping 442 matching lines @@
   result.set_token_pos(token_pos);
   result.set_end_token_pos(token_pos);
   result.set_num_fixed_parameters(0);
   result.set_num_optional_parameters(0);
   result.set_usage_counter(0);
   result.set_deoptimization_counter(0);
   result.set_optimized_instruction_count(0);
   result.set_optimized_call_site_count(0);
   result.set_is_optimizable(is_native ? false : true);
   result.set_is_inlinable(true);
-  if (kind == RawFunction::kClosureFunction) {
+  if ((kind == RawFunction::kClosureFunction) ||
+      (kind == RawFunction::kGetFieldClosure) ||
+      (kind == RawFunction::kSetFieldClosure) ) {
     const ClosureData& data = ClosureData::Handle(ClosureData::New());
     result.set_data(data);
   }
   return result.raw();
 }
 
 
 RawFunction* Function::Clone(const Class& new_owner) const {
   ASSERT(!IsConstructor());
   Function& clone = Function::Handle();
@@ skipping 462 matching lines @@
       break;
     case RawFunction::kMethodExtractor:
       kind_str = " method-extractor";
       break;
     case RawFunction::kNoSuchMethodDispatcher:
       kind_str = " no-such-method-dispatcher";
       break;
     case RawFunction::kInvokeFieldDispatcher:
       kind_str = "invoke-field-dispatcher";
       break;
+    case RawFunction::kGetFieldClosure:
+      kind_str = "get-field-closure";
+      break;
+    case RawFunction::kSetFieldClosure:
+      kind_str = "set-field-closure";
+      break;
     default:
       UNREACHABLE();
   }
   const char* kFormat = "Function '%s':%s%s%s%s.";
   const char* function_name = String::Handle(name()).ToCString();
   intptr_t len = OS::SNPrint(NULL, 0, kFormat, function_name,
                              static_str, abstract_str, kind_str, const_str) + 1;
   char* chars = Isolate::Current()->current_zone()->Alloc<char>(len);
   OS::SNPrint(chars, len, kFormat, function_name,
               static_str, abstract_str, kind_str, const_str);
@@ skipping 11219 matching lines @@
   return "_MirrorReference";
 }
 
 
 void MirrorReference::PrintToJSONStream(JSONStream* stream, bool ref) const {
   Instance::PrintToJSONStream(stream, ref);
 }
 
 
 }  // namespace dart