Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1358803002: Add ninja console pool support to GN (Closed)

Created:
5 years, 3 months ago by tsniatowski
Modified:
5 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ninja console pool support to GN Allow GN actions to specify "console = true", which will translate into a "pool = console" setting in the generated ninja files. The console pool allows a ninja target to have unbuffered io, access to standard input, and is limited to one target at a time. R=brettw@chromium.org BUG= Committed: https://crrev.com/b52c507ecb15e3eaf6051cba0de0cbaf69fe200a Cr-Commit-Position: refs/heads/master@{#350321}

Patch Set 1 #

Patch Set 2 : Hook up help for the new var #

Patch Set 3 : update action/action_foreach doc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -6 lines) Patch
M tools/gn/action_target_generator.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gn/action_target_generator.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M tools/gn/action_values.h View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/gn/action_values.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M tools/gn/functions_target.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/ninja_action_target_writer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/gn/ninja_action_target_writer_unittest.cc View 1 chunk +43 lines, -0 lines 0 comments Download
M tools/gn/variables.h View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/gn/variables.cc View 1 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
tsniatowski
Having something like this in GN would make some of the heavy-lifting actions we have ...
5 years, 3 months ago (2015-09-21 09:30:55 UTC) #1
tsniatowski
On 2015/09/21 09:30:55, tsniatowski wrote: > Having something like this in GN would make some ...
5 years, 3 months ago (2015-09-21 09:35:06 UTC) #2
brettw
Interesting. Can you add "console" to the list of variables accepted by action and action_foreach ...
5 years, 3 months ago (2015-09-22 19:35:03 UTC) #3
tsniatowski
On 2015/09/22 19:35:03, brettw wrote: > Interesting. > > Can you add "console" to the ...
5 years, 3 months ago (2015-09-23 06:28:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358803002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358803002/40001
5 years, 3 months ago (2015-09-23 06:28:44 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-23 06:44:24 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 06:44:57 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b52c507ecb15e3eaf6051cba0de0cbaf69fe200a
Cr-Commit-Position: refs/heads/master@{#350321}

Powered by Google App Engine
This is Rietveld 408576698