Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: tools/gn/action_target_generator.cc

Issue 1358803002: Add ninja console pool support to GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update action/action_foreach doc Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/action_target_generator.h ('k') | tools/gn/action_values.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/action_target_generator.cc
diff --git a/tools/gn/action_target_generator.cc b/tools/gn/action_target_generator.cc
index 3cd4e4756fb038a5ad1d941da9b149c93a7320f2..40523fe08b94ecd12bf00cf4dac9ee1994f74db4 100644
--- a/tools/gn/action_target_generator.cc
+++ b/tools/gn/action_target_generator.cc
@@ -54,6 +54,9 @@ void ActionTargetGenerator::DoRun() {
if (!FillDepfile())
return;
+ if (!FillConsole())
+ return;
+
if (!FillCheckIncludes())
return;
@@ -107,6 +110,16 @@ bool ActionTargetGenerator::FillDepfile() {
return true;
}
+bool ActionTargetGenerator::FillConsole() {
+ const Value* value = scope_->GetValue(variables::kConsole, true);
+ if (!value)
+ return true;
+ if (!value->VerifyTypeIs(Value::BOOLEAN, err_))
+ return false;
+ target_->action_values().set_console(value->boolean_value());
+ return true;
+}
+
bool ActionTargetGenerator::CheckOutputs() {
const SubstitutionList& outputs = target_->action_values().outputs();
if (outputs.list().empty()) {
« no previous file with comments | « tools/gn/action_target_generator.h ('k') | tools/gn/action_values.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698