Implement WebContentsModalDialogManagerDelegate for ShellWindow

chrome/browser/ui/gtk/extensions/native_app_window_gtk.h

Index: chrome/browser/ui/gtk/extensions/native_app_window_gtk.h
diff --git a/chrome/browser/ui/gtk/extensions/native_app_window_gtk.h b/chrome/browser/ui/gtk/extensions/native_app_window_gtk.h
index 701675770ba4f5f27cc92593b761a4dd56c65fac..230346206d57b854f127ecc63f90f278b13e4991 100644
--- a/chrome/browser/ui/gtk/extensions/native_app_window_gtk.h
+++ b/chrome/browser/ui/gtk/extensions/native_app_window_gtk.h
@@ -7,6 +7,7 @@
 
 #include <gtk/gtk.h>
 
+#include "base/observer_list.h"

[jeremya, 2013/04/04 19:59:17]

Would it make more sense to have ShellWindow be the HostDelegate, rather than
adding an observer list to each native implementation separately?

[Mike Wittman, 2013/04/04 22:56:08]

I don't think so. The NativeWidget subclasses are the natural classes to
implement the HostDelegate since those are where the positioning computation and
knowledge of when the positioning requires updating resides. Doing the
notification in ShellWindow would be undesirable because it would split the
responsibility of implementing the interface across two classes.

 #include "base/timer.h"
 #include "chrome/browser/ui/extensions/native_app_window.h"
 #include "chrome/browser/ui/extensions/shell_window.h"
@@ -67,6 +68,14 @@ class NativeAppWindowGtk : public NativeAppWindow,
   virtual void RenderViewHostChanged() OVERRIDE;
   virtual gfx::Insets GetFrameInsets() const OVERRIDE;
 
+  // WebContentsModalDialogHost implementation.
+  virtual gfx::Point GetDialogPosition(const gfx::Size& size) OVERRIDE;
+
+  virtual void AddObserver(
+      WebContentsModalDialogHostObserver* observer) OVERRIDE;
+  virtual void RemoveObserver(
+      WebContentsModalDialogHostObserver* observer) OVERRIDE;
+
   content::WebContents* web_contents() const {
     return shell_window_->web_contents();
   }
@@ -140,6 +149,10 @@ class NativeAppWindowGtk : public NativeAppWindow,
   // into events and sent to the extension.
   scoped_ptr<ExtensionKeybindingRegistryGtk> extension_keybinding_registry_;
 
+  // Observers to be notified when any web contents modal dialog requires
+  // updating its dimensions.
+  ObserverList<WebContentsModalDialogHostObserver> observer_list_;
+
   DISALLOW_COPY_AND_ASSIGN(NativeAppWindowGtk);
 };