Implement WebContentsModalDialogManagerDelegate for ShellWindow

chrome/browser/ui/gtk/extensions/native_app_window_gtk.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_GTK_EXTENSIONS_NATIVE_APP_WINDOW_GTK_H_
 #define CHROME_BROWSER_UI_GTK_EXTENSIONS_NATIVE_APP_WINDOW_GTK_H_
 
 #include <gtk/gtk.h>
 
+#include "base/observer_list.h"

[jeremya, 2013/04/04 19:59:17]

Would it make more sense to have ShellWindow be the HostDelegate, rather than
adding an observer list to each native implementation separately?

[Mike Wittman, 2013/04/04 22:56:08]

I don't think so. The NativeWidget subclasses are the natural classes to
implement the HostDelegate since those are where the positioning computation and
knowledge of when the positioning requires updating resides. Doing the
notification in ShellWindow would be undesirable because it would split the
responsibility of implementing the interface across two classes.

 #include "base/timer.h"
 #include "chrome/browser/ui/extensions/native_app_window.h"
 #include "chrome/browser/ui/extensions/shell_window.h"
 #include "chrome/browser/ui/gtk/extensions/extension_view_gtk.h"
 #include "third_party/skia/include/core/SkRegion.h"
 #include "ui/base/gtk/gtk_signal.h"
 #include "ui/base/x/active_window_watcher_x_observer.h"
 #include "ui/gfx/rect.h"
 
 class ExtensionKeybindingRegistryGtk;
@@ skipping 40 matching lines @@
   virtual bool IsFullscreenOrPending() const OVERRIDE;
   virtual void UpdateWindowIcon() OVERRIDE;
   virtual void UpdateWindowTitle() OVERRIDE;
   virtual void HandleKeyboardEvent(
       const content::NativeWebKeyboardEvent& event) OVERRIDE;
   virtual void UpdateDraggableRegions(
       const std::vector<extensions::DraggableRegion>& regions) OVERRIDE;
   virtual void RenderViewHostChanged() OVERRIDE;
   virtual gfx::Insets GetFrameInsets() const OVERRIDE;
 
+  // WebContentsModalDialogHost implementation.
+  virtual gfx::Point GetDialogPosition(const gfx::Size& size) OVERRIDE;
+
+  virtual void AddObserver(
+      WebContentsModalDialogHostObserver* observer) OVERRIDE;
+  virtual void RemoveObserver(
+      WebContentsModalDialogHostObserver* observer) OVERRIDE;
+
   content::WebContents* web_contents() const {
     return shell_window_->web_contents();
   }
   const extensions::Extension* extension() const {
     return shell_window_->extension();
   }
 
   virtual ~NativeAppWindowGtk();
 
   // If the point (|x|, |y|) is within the resize border area of the window,
@@ skipping 53 matching lines @@
   GdkCursor* frame_cursor_;
 
   // The timer used to save the window position for session restore.
   base::OneShotTimer<NativeAppWindowGtk> window_configure_debounce_timer_;
 
   // The Extension Keybinding Registry responsible for registering listeners for
   // accelerators that are sent to the window, that are destined to be turned
   // into events and sent to the extension.
   scoped_ptr<ExtensionKeybindingRegistryGtk> extension_keybinding_registry_;
 
+  // Observers to be notified when any web contents modal dialog requires
+  // updating its dimensions.
+  ObserverList<WebContentsModalDialogHostObserver> observer_list_;
+
   DISALLOW_COPY_AND_ASSIGN(NativeAppWindowGtk);
 };
 
 #endif  // CHROME_BROWSER_UI_GTK_EXTENSIONS_NATIVE_APP_WINDOW_GTK_H_