Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1358793002: Revert of update memset16/32 inlining heuristics (Closed)

Created:
5 years, 3 months ago by mtklein
Modified:
5 years, 3 months ago
Reviewers:
jcgregorio, mtklein_C, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of update memset16/32 inlining heuristics (patchset #1 id:1 of https://codereview.chromium.org/1357193002/ ) Reason for revert: Who wants to land forever? Original issue's description: > update memset16/32 inlining heuristics > > I spent some time looking at perf.skia.org and it looks like we can do better. > > It is weird, weird, weird that on x86, we see three completely different behaviors: > - x86 Android: inlining better for small N, custom better for large N; > - Windows: inlining better for large N, custom better for small N; > - other x86: inlining generally better > > BUG=skia:4316, chromium:516426 > > (Temporary, plan to revert.) > TBR=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/b68fa409fc00ce2f38e2a0fd6f9dc2379b372481 TBR=reed@google.com,jcgregorio@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4316, chromium:516426 Committed: https://skia.googlesource.com/skia/+/b63d816683a8fe2d95e4ca7754034204c8bc10d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M include/core/SkUtils.h View 3 chunks +15 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Created Revert of update memset16/32 inlining heuristics
5 years, 3 months ago (2015-09-20 22:02:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1358793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1358793002/1
5 years, 3 months ago (2015-09-20 22:02:51 UTC) #2
commit-bot: I haz the power
5 years, 3 months ago (2015-09-20 22:02:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b63d816683a8fe2d95e4ca7754034204c8bc10d5

Powered by Google App Engine
This is Rietveld 408576698