Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 135863002: Reland Merge NativeTextfieldViews into views::Textfield. (Closed)

Created:
6 years, 11 months ago by msw
Modified:
6 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, benquan, tfarina, jam, penghuang+watch_chromium.org, dcheng, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, ben+views_chromium.org, James Su, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Reland Merge NativeTextfieldViews into views::Textfield. Reverted in r244402 for Linux-Aura test failures. I fixed Ctrl+Shift+Delete/Backspace behavior on Linux here. Consolidate the split textfield code into Textfield. No behavior changes (except STYLE_LOWERCASE GetText nit). Use the underlying model's text and font_list storage. Remove unused code; rename TextfieldViewsModel::text(). Revise gesture and command handling. Skip NotifyAccessibilityEvent native behavior without widget. (No HWND for Views not yet added to view hierarchy) Make TouchEditable::GetNativeView const; avoids conflict. Fix includes, forward decls, Font[List] usage, tests. Ideas for followup cleanup and refactoring: -Cleanup View overrides decl/def order. -Refactor RemoveBorder, SetHorizontalMargins, etc. -Try to use composition instead of inheritance. -Remove textfield style ctor; refactor style code. -Remove STYLE_LOWERCASE functionality (one user). -Replace placeholder DrawStringRect with a Label view. -Cleanup CreateTouchSelectionControllerAndNotifyIt, etc. -Cleanup SetColor/SetTextColor, etc. BUG=131660 TEST=No textfield behavior/appearance regressions. TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244436

Patch Set 1 #

Patch Set 2 : Handle Ctrl-Shift-Delete and Backspace on Linux, like on ChromeOS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2020 lines, -5013 lines) Patch
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/autofill/decorated_textfield.h View 3 chunks +7 lines, -18 lines 0 comments Download
M chrome/browser/ui/views/autofill/decorated_textfield.cc View 6 chunks +39 lines, -55 lines 0 comments Download
D chrome/browser/ui/views/autofill/decorated_textfield_unittest.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/browser/ui/views/cookie_info_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/dropdown_bar_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/find_bar_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/find_bar_view.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.h View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 8 chunks +56 lines, -56 lines 0 comments Download
M chrome/browser/ui/views/password_generation_bubble_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/folder_header_view.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/app_list/views/search_box_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/touch/touch_editing_controller.h View 1 chunk +1 line, -1 line 0 comments Download
D ui/views/controls/textfield/native_textfield_views.h View 1 chunk +0 lines, -397 lines 0 comments Download
D ui/views/controls/textfield/native_textfield_views.cc View 1 chunk +0 lines, -1528 lines 0 comments Download
D ui/views/controls/textfield/native_textfield_views_unittest.cc View 1 chunk +0 lines, -2002 lines 0 comments Download
M ui/views/controls/textfield/textfield.h View 9 chunks +209 lines, -110 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 14 chunks +1203 lines, -223 lines 0 comments Download
M ui/views/controls/textfield/textfield_controller.h View 1 chunk +0 lines, -20 lines 0 comments Download
M ui/views/controls/textfield/textfield_controller.cc View 1 chunk +0 lines, -16 lines 0 comments Download
A + ui/views/controls/textfield/textfield_unittest.cc View 1 63 chunks +196 lines, -230 lines 0 comments Download
M ui/views/controls/textfield/textfield_views_model.h View 7 chunks +26 lines, -30 lines 0 comments Download
M ui/views/controls/textfield/textfield_views_model.cc View 20 chunks +46 lines, -49 lines 0 comments Download
M ui/views/controls/textfield/textfield_views_model_unittest.cc View 31 chunks +181 lines, -187 lines 0 comments Download
M ui/views/ime/input_method_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/touchui/touch_selection_controller_impl_unittest.cc View 18 chunks +28 lines, -33 lines 0 comments Download
M ui/views/view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/views.gyp View 2 chunks +1 line, -3 lines 0 comments Download
M ui/views/widget/widget.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/135863002/70001
6 years, 11 months ago (2014-01-12 03:15:13 UTC) #1
commit-bot: I haz the power
6 years, 11 months ago (2014-01-12 06:12:02 UTC) #2
Message was sent while issue was closed.
Change committed as 244436

Powered by Google App Engine
This is Rietveld 408576698