chrome/browser/ui/views/omnibox/omnibox_view_views.h - Issue 135863002: Reland Merge NativeTextfieldViews into views::Textfield.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.h

Issue 135863002: Reland Merge NativeTextfieldViews into views::Textfield. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Handle Ctrl-Shift-Delete and Backspace on Linux, like on ChromeOS. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.h

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.h b/chrome/browser/ui/views/omnibox/omnibox_view_views.h

index 70ee35ca7338f7c43095b84fa93792d15b572213..07154a3363cb2d935240cda2e90db510539df1a3 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.h

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.h

@@ -110,6 +110,10 @@ class OmniboxViewViews

virtual int GetWidth() const OVERRIDE;

virtual bool IsImeComposing() const OVERRIDE;

virtual bool IsImeShowingPopup() const OVERRIDE;

+ virtual bool IsCommandIdEnabled(int command_id) const OVERRIDE;

+ virtual bool IsItemForCommandIdDynamic(int command_id) const OVERRIDE;

+ virtual base::string16 GetLabelForCommandId(int command_id) const OVERRIDE;

+ virtual void ExecuteCommand(int command_id, int event_flags) OVERRIDE;

// views::TextfieldController:

virtual void ContentsChanged(views::Textfield* sender,

@@ -126,11 +130,6 @@ class OmniboxViewViews

std::set<ui::OSExchangeData::CustomFormat>* custom_formats) OVERRIDE;

virtual int OnDrop(const ui::OSExchangeData& data) OVERRIDE;

virtual void UpdateContextMenu(ui::SimpleMenuModel* menu_contents) OVERRIDE;

- virtual bool IsCommandIdEnabled(int command_id) const OVERRIDE;

- virtual bool IsItemForCommandIdDynamic(int command_id) const OVERRIDE;

- virtual base::string16 GetLabelForCommandId(int command_id) const OVERRIDE;

- virtual bool HandlesCommand(int command_id) const OVERRIDE;

- virtual void ExecuteCommand(int command_id, int event_flags) OVERRIDE;

#if defined(OS_CHROMEOS)

// chromeos::input_method::InputMethodManager::CandidateWindowObserver: