NaCl: Expose NaClApp to embedding layer.

src/trusted/service_runtime/sel_main_chrome.h

Index: src/trusted/service_runtime/sel_main_chrome.h
diff --git a/src/trusted/service_runtime/sel_main_chrome.h b/src/trusted/service_runtime/sel_main_chrome.h
index 043575cf72ac82a7cdc6bfce5ad0340cae034e15..bc124eec72c106c7d07c1636ea1226a6c04897de 100644
--- a/src/trusted/service_runtime/sel_main_chrome.h
+++ b/src/trusted/service_runtime/sel_main_chrome.h
@@ -153,6 +153,12 @@ struct NaClChromeMainArgs {
 struct NaClChromeMainArgs *NaClChromeMainArgsCreate(void);
 
 /* Launch NaCl. */
+struct NaClApp;
+struct NaClApp* NaClAppCreate(void);

[Mark Seaborn, 2014/01/17 16:42:06]

Why do you want to do the interface like this rather than the version from
https://code.google.com/p/chromium/issues/detail?id=333950, which was:

  struct NaClApp *NaClChromeMainCreateApp(struct NaClChromeMainArgs *args);

That seemed a little cleaner as an embedding interface because it returns a
NaClApp that is more fully initialised.

For consistency, NaClAppCreate() should be named "*Make" rather than "*Create"
(matching other functions in the NaCl codebase), and should really have a
"NaClChromeMain" prefix to match the rest of this header file.

+void NaClChromeMainStartApp(struct NaClApp *app,
+                            struct NaClChromeMainArgs *args);
+
+/* DEPRECATED. TODO(teravest): Remove. */
 void NaClChromeMainStart(struct NaClChromeMainArgs *args);